x86_64: Cleanup xenmgr_vm interface #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-edouard
requested changes
Mar 14, 2019
jean-edouard
approved these changes
Mar 14, 2019
The VM interface actually duplicates almost every property and method. com.citrix.xenclient.xenmgr.vm and com.citrix.xenclient.xenmgr.vm.unrestricted The properties being removed have are from the unrestricted interface and have no backend implementation in Xenmgr. Therefore, extra code is being autogenerated that doesn't need to be. Also we shouldn't advertise functions that don't actually exist. One property is higher up in the file to match where it's found in Xenmgr's VmObject.hs file. This is an organizational change. Overall, these changes are cleanup only and are not x64 dependent. Signed-off-by: Chris <[email protected]>
crogers1
changed the title
|
After looking over this PR again, it can just be closed. I made a mistake looking at my manager.git repo and assumed these changes were needed. I'll also be updating my manager.git PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VM interface actually duplicates almost every property and method.
com.citrix.xenclient.xenmgr.vm and
com.citrix.xenclient.xenmgr.vm.unrestricted
The properties being removed have are from the unrestricted interface
and have no backend implementation in Xenmgr. Therefore, extra code
is being autogenerated that doesn't need to be. Also we shouldn't
advertise functions that don't actually exist.
One property is higher up in the file to match where it's found
in Xenmgr's VmObject.hs file. This is an organizational change.
Overall, these changes are cleanup only and are not x64 dependent.
Signed-off-by: Chris [email protected]