Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Scarb Workspaces and Modularize Codebase #1038

Closed
wants to merge 2 commits into from

Conversation

ametel01
Copy link
Contributor

@ametel01 ametel01 commented Jul 7, 2024

Fixes #734

Changes Introduced

This PR implements Scarb workspaces and breaks down the OpenZeppelin Cairo contracts codebase into packages to improve modularity. This allows developers to import only the required libraries in a more granular manner, enhancing both usability and maintainability.

Current Status

The PR is currently in draft status. Before proceeding further, I need the maintainers' opinions on how to best integrate the existing tests into their respective new packages. Any guidance on this integration will be greatly appreciated.

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

@andrew-fleming
Copy link
Collaborator

Thanks for opening this PR, @ametel01!

Before proceeding further, I need the maintainers' opinions on how to best integrate the existing tests into their respective new packages. Any guidance on this integration will be greatly appreciated.

Give us a little time to review and think about this and we'll provide feedback

@ericnordelo
Copy link
Member

Hey @ametel01, thanks for taking the time. This is a solid base for the migration. Since we are still missing test organization, the test utils package, documentation updates around it, and workflows fix (class hashes update check, etc...), this PR can become quite big and complex to review. Then, I think it would be easier if we take it from here, keeping your contributions (commits). We had this as part of our next milestone, so we should be working on it very soon (it will be part of the next release).

@ericnordelo
Copy link
Member

Thanks again @ametel01! Superseded by #1065.

@ametel01
Copy link
Contributor Author

Hey @ericnordelo happy to have jumpstarted the transition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: use Scarb workspaces
3 participants