-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage to our test workflow #1152
Conversation
Should we define rules and add a codecov configuration file similar to what we have in solidity? |
@ericnordelo it is not needed to have an initial coverage report, but I did take the opportunity and added a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
=========================================
+ Coverage 0 89.35% +89.35%
=========================================
Files 0 55 +55
Lines 0 1334 +1334
=========================================
+ Hits 0 1192 +1192
- Misses 0 142 +142 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Eric Nordelo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left a question
Fixes #1129
Description
--coverage
flag to the test stepI was planning to add this in our next milestone, but it was much easier than I expected. I tested it on my branch and the coverage report was generated and uploaded to codecov, but since
cairo-coverage
does not support branch coverage yet, I don't know exactly what the final report looks like(we will see once it is merged to main)