Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add erc4626 #1170
base: main
Are you sure you want to change the base?
Add erc4626 #1170
Changes from 70 commits
82b3173
f08dd48
c558c59
0b572e5
3cadd55
f66bce4
5d7b1d9
33bd0d4
ce22c2f
4fefde2
80c4013
7e4177f
3def693
77fdfa6
dc66804
b05f57e
ea3bf06
f5ce03b
e70061d
ca52772
8072770
7d2a3c1
a45c8dc
bb1cdc2
f2681e5
f401df1
4bdde8d
ccc8784
87a84ab
501d7b9
ee222f5
970cb75
39b205c
5af5b8b
69c4831
b735b5d
43440d0
56cea65
0870930
65dddfc
bded58f
fd4d146
2bf3aac
9c7243f
bb3a6b0
c8a9dfa
385118e
bc88cf8
1d14afc
acc2047
2e368fd
c4f565e
c343716
0e10817
cbdd70a
970d621
1418543
a10b28c
e67d312
ed727df
b7fb9de
44055bd
8d8e066
450efa4
d912c6d
0cd10da
3ef163f
4fcdd0c
c8b7161
1c221a5
ed01a88
58d26be
c699dc4
0ec51cf
f84d7d1
dd81898
960f338
b147fb4
978ac98
533f7ba
84e3681
9a6a14a
9c69ca2
0c3f8e0
8852efe
8729faa
fc09ba9
cf24a40
6462c6c
8722e2d
2de96c5
4eb0b83
894e43b
379f874
3e8f237
02206f0
4263919
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clear the calldata that already exists to allow for a repeated call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't have to. There's only one reentrant call since we're setting the reentrant
Type
toNo
in the hooks after the initial call