Minor improvements for the finance module #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
+ Coverage 92.03% 92.06% +0.02%
==========================================
Files 49 49
Lines 1394 1398 +4
==========================================
+ Hits 1283 1287 +4
Misses 111 111
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
immrsd
approved these changes
Nov 13, 2024
| Requirements: | ||
|
|
||
| - `transfer` call to the `token` must return `true` indicating a successful transfer. | ||
|
|
||
| Emits {AmountReleased} event. | ||
| May emit an {AmountReleased} event. |
There was a problem hiding this comment.
Shall we specify here when an event won't be emitted? It feels bit weird given no context
There was a problem hiding this comment.
Do you think the NOTE in the description is not enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.