Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to the merkle tree package #1213

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

andrew-fleming
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (4d40f5e) to head (82cf17f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          49       49           
  Lines        1394     1394           
=======================================
  Hits         1283     1283           
  Misses        111      111           
Files with missing lines Coverage Δ
packages/merkle_tree/src/hashes.cairo 88.88% <ø> (ø)
packages/merkle_tree/src/merkle_proof.cairo 82.35% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d40f5e...82cf17f. Read the comment docs.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-fleming andrew-fleming merged commit 043f069 into OpenZeppelin:main Nov 15, 2024
8 checks passed
@andrew-fleming andrew-fleming deleted the preaudit-merkle branch November 15, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants