Skip to content

Update account generation to use code from 5.4.0-rc.1 #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Jun 20, 2025

Upgradeable version is a bit challenging because only part of the parent contracts must be used in their upgradeable version.

Only contract that should be used from the upgradeable packages are:

draft-AccountERC7579Hooked.sol
draft-AccountERC7579HookedUpgradeable.sol
MultiSignerERC7913Upgradeable.sol
MultiSignerERC7913WeightedUpgradeable.sol
SignerECDSAUpgradeable.sol
SignerERC7913Upgradeable.sol
SignerP256Upgradeable.sol
SignerRSAUpgradeable.sol

while EIP712, and ERC7739 have an upgradeable version, they should not be used here. Using the vanila version of EIP712 so that the domain doesn't have to be initialized, and is shared accross all clones/proxies.

Copy link

socket-security bot commented Jun 20, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@Amxx Amxx marked this pull request as ready for review June 20, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant