Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow referencing existing Defender resources #27

Merged

Conversation

Copy link
Member

@MCarlomagno MCarlomagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only concern is about security, is it possible to reference resources from another tenant? Let's say I see the actionId from another tenant in the forum and I attack that tenant triggering that action using a monitor from my own tenant, would that be possible?

src/cmd/deploy.ts Show resolved Hide resolved
src/cmd/deploy.ts Show resolved Hide resolved
src/types/types/resources.schema.d.ts Show resolved Hide resolved
@shahnami
Copy link
Member Author

LGTM, my only concern is about security, is it possible to reference resources from another tenant? Let's say I see the actionId from another tenant in the forum and I attack that tenant triggering that action using a monitor from my own tenant, would that be possible?

These are secured by tenant-scoped API keys (since it uses defender-sdk). When a reference is made, we try to pull that data in during, for example, the deploy, but if the user doesn't have access to that resource, the authoriser will throw.

@shahnami shahnami merged commit efe1439 into main Oct 28, 2023
3 checks passed
@shahnami shahnami deleted the plat-2817-allow-defender-as-code-to-reference-existing-resources branch October 28, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants