-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow referencing existing Defender resources #27
Allow referencing existing Defender resources #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only concern is about security, is it possible to reference resources from another tenant? Let's say I see the actionId from another tenant in the forum and I attack that tenant triggering that action using a monitor from my own tenant, would that be possible?
These are secured by tenant-scoped API keys (since it uses defender-sdk). When a reference is made, we try to pull that data in during, for example, the deploy, but if the user doesn't have access to that resource, the authoriser will throw. |
https://linear.app/openzeppelin-development/issue/PLAT-2817/allow-defender-as-code-to-reference-existing-resources