Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case with 1 abi type event #44

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix edge case with 1 abi type event #44

merged 2 commits into from
Feb 23, 2024

Conversation

shahnami
Copy link
Member

No description provided.

peersky
peersky reviewed Feb 22, 2024
View reviewed changes
Copy link

@peersky peersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification regarding changing ArrayABI schema requested. Otherwise looks good to me.

src/utils/index.ts Show resolved Hide resolved
src/types/docs-schemas/definitions.schema.json Show resolved Hide resolved
MCarlomagno
MCarlomagno approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@MCarlomagno MCarlomagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context but I leave the approval, just to unblock you in case this is ready to merge

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@openzeppelin/[email protected] Transitive: environment, filesystem, network +99 31 MB collins-oz, dylkil, frangio, ...4 more

🚮 Removed packages: npm/@openzeppelin/[email protected]

View full report↗︎

@peersky peersky self-requested a review February 23, 2024 13:32
peersky
peersky approved these changes Feb 23, 2024
View reviewed changes
Copy link

@peersky peersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahnami shahnami merged commit c72e393 into main Feb 23, 2024
4 checks passed
@shahnami shahnami deleted the plat-3885-sls-deploy-error-when-monitor-abi-is-array-of-exactly-one branch February 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peersky peersky peersky approved these changes

@MCarlomagno MCarlomagno MCarlomagno approved these changes

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahnami @MCarlomagno @peersky