Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes Issue #325] Update types for ProposalFunctionInputs to match API documentation #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fixes Issue #325] Update types for ProposalFunctionInputs to match API documentation #324

wants to merge 1 commit into from

Conversation

bstchow
Copy link

@bstchow bstchow commented Sep 26, 2023

See documentation in https://docs.openzeppelin.com/defender/v1/admin-api-reference

type ProposalFunctionInputsArray = (string | boolean)[];
type ProposalFunctionInputs = (
  | string
  | boolean
  | (string | boolean | (string | boolean | (string | boolean | ProposalFunctionInputsArray)[])[])[]
)[];

@bstchow bstchow mentioned this pull request Sep 26, 2023
Open
@bstchow bstchow changed the title [types] Update types for ProposalFunctionInputs to match API documentation [Fixes Issue #325] Update types for ProposalFunctionInputs to match API documentation Sep 26, 2023
@MCarlomagno
Copy link
Member

@bstchow LGTM thanks for the contribution!

@daltyboy11
Copy link

@MCarlomagno can we get this in the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bstchow @MCarlomagno @daltyboy11