Fix the lerna publish for the npm packages #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirumerla
reviewed
Nov 16, 2023
.github/workflows/rc.yml
Outdated
Comment on lines
40
to
42
| needs: check_author | ||
| runs-on: ubuntu-22.04 | ||
| if: ${{ needs.check_author.outputs.latest_commit_author != 'svc-gh-is-01' }} |
There was a problem hiding this comment.
we shouldn't remove this otherwise it would get into infinite loop everytime there is a push by svc user.
tirumerla
reviewed
Nov 16, 2023
.github/workflows/publish.yml
Outdated
Comment on lines
70
to
72
| - name: Enable NPM PROVENANCE | ||
| run: echo "NPM_CONFIG_PROVENANCE=true" >> $GITHUB_ENV | ||
|
|
|
@tirumerla please take a look. |
tirumerla
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
LGTM, thanks @collins-w great work. One quick question since we are running everyday as a nightly job can we make sure that we are not creating multiple rc packages of the same commit everyday. I guess tag_check_changes will validate that, if not we could also add a condition to check latest commit hash with the tagged commit hash if it's different we push the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Publish 1.49.0-rc to npm and/or fix install and build #380