Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to matic zkevm #506

Merged
merged 2 commits into from
May 2, 2024

Conversation

MCarlomagno
Copy link
Member

No description provided.

@biga816
Copy link

biga816 commented Mar 15, 2024

When is this PR merged? I think the dont-merge label can be removed because Polygon zkEVM is already supported on the Defender dashboard.

@biga816
Copy link

biga816 commented May 2, 2024

@zeljkoX @MCarlomagno Do you have a plan to support Polygon zkEVM in this module?
If yes, I would appreciate it if you could merge this PR. I want to use it in my project.

@MCarlomagno
Copy link
Member Author

@biga816 Thanks for the heads up on this, I added the dont-merge label due to some issues in the network integration that we already solved. This PR was stale because this repo is being deprecated in favor of defender-sdk.

We can merge this PR and release a new version for defender-client, but I suggest you to consider moving to defender-sdk soon to avoid breaking changes in this client after sunset.

Copy link
Contributor

@tirumerla tirumerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tirumerla tirumerla merged commit 29e294b into master May 2, 2024
6 checks passed
@tirumerla tirumerla deleted the plat-2587-add-support-for-polygon-zkevm branch May 2, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants