-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cairo: use release branches instead of tags #419
Cairo: use release branches instead of tags #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericnordelo this looks good.
- I think we are missing one release branch that is in the docs site(0.15.0-rc.0). I don't think this is a big issue, so I think we are ok removing this
- There are a few release branches that we don't have published in the docs and would appear now(0.2.0, 0.2.1, 0.7.0-rc.0). Here I suggest we solve this issue first.
Also would be great if we can get a preview before pushing this changes. I think @ericglau has to trigger the workflow?
I removed the release candidates, beta releases, and release branches previous to v0.7.0 (cairo 0) from the cairo-contracts repository. Waiting for the deploy-preview as pointed by @ggonzalez94 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview is deployed
Updated to doc branches instead, since we already use release branches for bumping the version on releases, and sometimes the docsite may be updated before the release is finished. cc @ggonzalez94 We have to add a doc branch to each corresponding version before merging this. |
Added a doc branch for every release after 0.10.0 and merged ERC20Permit doc into docs-v0.18.0. Is there a way to re-launch the deploy preview @ericglau? @ggonzalez94 waiting for your confirmation to merge in case you prefer a different approach. |
Redeploy failed with error:
|
Whoops. Version conflicts fixed @ericglau. |
Redeployment succeeded at https://deploy-preview-419--openzeppelin-docs.netlify.app/ |
@ggonzalez94 a kindly reminder that the sooner we merge this the sooner we get ERC20Permit entries in the docsite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericnordelo looks good sorry for the delay. Can you please update our release process to include the step of creating the docs branch from the release branch?
Thanks!
@ericglau I think we need one final deploy preview before merging this, could you please approve it? 🙏 |
OpenZeppelin/cairo-contracts#1195 Done! |
I've redeployed the preview. |
This should work out of the box since each release has a release branch.