Skip to content

refactor(ERC20FlashMint): remove unused parameter suppression in _flashFee #5982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor(ERC20FlashMint): remove unused parameter suppression in _flashFee #5982

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89c374f
Update ERC20FlashMint.sol
sashaodessa Oct 9, 2025
717b774
Update contracts/token/ERC20/extensions/ERC20FlashMint.sol
sashaodessa Oct 9, 2025
f8fa15b
Remove params for _flashFee
ernestognw Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions contracts/token/ERC20/extensions/ERC20FlashMint.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,10 @@ abstract contract ERC20FlashMint is ERC20, IERC3156FlashLender {
* @dev Returns the fee applied when doing flash loans. By default this
* implementation has 0 fees. This function can be overloaded to make
* the flash loan mechanism deflationary.
* @param token The token to be flash loaned.
* @param value The amount of tokens to be loaned.
*
* @return The fees applied to the corresponding flash loan.
*/
function _flashFee(address token, uint256 value) internal view virtual returns (uint256) {
// silence warning about unused variable without the addition of bytecode.
token;
value;
function _flashFee(address /*token*/, uint256 /*value*/) internal view virtual returns (uint256) {
return 0;
}

Expand Down
Loading