- 
                Notifications
    
You must be signed in to change notification settings  - Fork 12.3k
 
docs: improvement of grammar #6035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
 | 
    
          
WalkthroughThis change updates documentation pages with grammar and style corrections throughout various sections. The primary substantive update involves MerkleTree method signatures, which now require an additional hash function parameter. Specifically, the  Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
 ✅ Passed checks (1 passed)
 ✨ Finishing touches🧪 Generate unit tests (beta)
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/modules/ROOT/pages/utilities.adoc (1)
293-295: Clarify transition between basic and custom hashing examples.The documentation now shifts from a basic MerkleTree example (without custom hash functions) to emphasizing custom hash functions as a sensitive operation. Consider adding an introductory sentence between lines 292 and 293 (after "These functions allow developers to...") that explicitly states: "For most use cases, the default hashing is sufficient; however, for advanced scenarios..."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/modules/ROOT/pages/eoa-delegation.adoc(1 hunks)docs/modules/ROOT/pages/utilities.adoc(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Redirect rules - solidity-contracts
 - GitHub Check: Header rules - solidity-contracts
 - GitHub Check: Pages changed - solidity-contracts
 - GitHub Check: tests-upgradeable
 - GitHub Check: tests
 - GitHub Check: coverage
 - GitHub Check: slither
 - GitHub Check: tests-foundry
 - GitHub Check: halmos
 
🔇 Additional comments (3)
docs/modules/ROOT/pages/eoa-delegation.adoc (1)
55-56: Correct subject-verb agreement.The change from "avoids" to "avoid" properly aligns the verb with its plural subject "signatures."
docs/modules/ROOT/pages/utilities.adoc (2)
258-258: Documentation prose improvements approved.The grammar and readability improvements across the Structures, Packing, and custom hashing functions sections enhance clarity without changing technical meaning. Changes maintain consistency with the overall documentation style.
Also applies to: 295-295, 349-349, 351-351
283-284: ****The documentation is accurate. The MerkleTree.sol source confirms that both
setup()andpush()have function overloads: one without the hash function parameter (defaulting toHashes.commutativeKeccak256) and one accepting a custom hash function. The two examples in utilities.adoc correctly demonstrate both use cases—basic usage without the parameter, then advanced usage with it—and the intermediate text properly explains that custom hashing functions can be passed as optional parameters.
No description provided.