Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Support contracts with the same name #1203 #1213

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

melnikaite
Copy link
Contributor

No description provided.

@jbcarpanelli
Copy link
Contributor

Hey @melnikaite, thanks for tackling this one! Let me know when it's ready for review 👍.

@melnikaite
Copy link
Contributor Author

Hi @jcarpanelli

I manage to successfully run oz push, but stuck with oz create, because it try to install contract/name as npm dependency, but obviously there is no such npm package and I didn't find the place where sdk check if it should run npm install

@melnikaite melnikaite force-pushed the fix/support-contracts-with-same-name-#1203 branch from 512680b to 4614d75 Compare September 11, 2019 14:11
@spalladino
Copy link
Contributor

Hey @melnikaite! Thanks for the contribution :-)
Is this the function you are looking for regarding installing an npm dependency?

public static async install(nameAndVersion: string): Promise<Dependency> {
Loggy.spin(__filename, 'install', `install-dependency-${nameAndVersion}`, `Installing ${nameAndVersion} via npm`);
await npm.install([nameAndVersion], { save: true, cwd: process.cwd() });
Loggy.succeed(`install-dependency-${nameAndVersion}`, `Dependency ${nameAndVersion} installed`);
return this.fromNameWithVersion(nameAndVersion);
}

@melnikaite
Copy link
Contributor Author

Yes, but in fact my issue was in fromContractFullName

It seems functionality works fine for all commands, but currently I don't have time to fix all the tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants