Upgrade generic-template to polkadot-stable2412 #401

4meta5 · 2025-01-10T18:33:07Z

Addresses #374 for generic-template only

Update: We are upgrading to this commit rather than any tagged release paritytech/polkadot-sdk#7467 because otherwise we hit the associated bug

Repo/Forks to Upgrade

ethereum https://github.com/OpenZeppelin/ethereum
evm Upgrade to polkadot-stable2412 evm#1
dancekit Upgrade to polkadot-stable2412 dancekit#1
moonkit Upgrade to polkadot-stable2412 moonkit#3
moonbeam Update to polkadot-stable2412 moonbeam#1
open runtime module library Upgrade to polkadot-stable2412... open-runtime-module-library#2
pallet abstractions Upgrade to polkadot-stable2412 openzeppelin-pallet-abstractions#65

Local Changes TODO

merge Support paying DOT as a fee #404 into main
merge main into this branch
get the CI green

Follow up(s)

make issue to replace commit with tagged release once tagged release is pushed [stable2412] Backport #7437 paritytech/polkadot-sdk#7467

netlify · 2025-01-10T18:33:33Z

✅ Deploy Preview for docs-oz-polkadot canceled.

Name	Link
🔨 Latest commit	`3c704f0`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-oz-polkadot/deploys/67b49c695e034a0008536c46

… required in pallet abstractions

…tible

KitHat · 2025-01-29T10:29:54Z

@4meta5 Option::is_none_or was stabilized in 1.82.0, nightly-2024-06-22 is 1.81.0 https://github.com/OpenZeppelin/polkadot-runtime-templates/actions/runs/12897801660/job/35963640920?pr=401#step:6:22

4meta5 · 2025-02-03T14:16:41Z

Dependency mismatch persists. I am debugging with cargo tree -d.

Here is the build error locally:

error[E0080]: evaluation of constant value failed
  --> /Users/4meta5/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/967989c/substrate/client/network/src/protocol/message.rs:79:40
   |
79 |     #[derive(Debug, PartialEq, Eq, Clone, Encode, Decode)]
   |                                           ^^^^^^ the evaluated program panicked at 'Found variants that have duplicate indexes. Both `Consensus` and `RemoteCallResponse` have the index `6`. Use different indexes for each variant.', /Users/4meta5/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/967989c/substrate/client/network/src/protocol/message.rs:79:43
   |
   = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `::core::panic` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0080]: evaluation of constant value failed
  --> /Users/4meta5/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/967989c/substrate/client/network/src/protocol/message.rs:79:48
   |
79 |     #[derive(Debug, PartialEq, Eq, Clone, Encode, Decode)]
   |                                                   ^^^^^^ the evaluated program panicked at 'Found variants that have duplicate indexes. Both `Consensus` and `RemoteCallResponse` have the index `6`. Use different indexes for each variant.', /Users/4meta5/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/967989c/substrate/client/network/src/protocol/message.rs:79:51
   |
   = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `::core::panic` (in Nightly builds, run with -Z macro-backtrace for more info)

4meta5 · 2025-02-10T13:57:11Z

I have updated all the fork versions to be <= the version of parity-scale-codec used in the polkadot-sdk used herein (<= 3.6.12). I am not sure what the problem is or if I need to fork the polkadot release tag in order to resolve this issue.

@KitHat can you please lend me a second pair of eyes to look over this dependency mismatch problem?

4meta5 · 2025-02-12T15:20:37Z

Thank you, confirmed that fix is paritytech/polkadot-sdk#7437 which was back ported into the branch stable2412 in paritytech/polkadot-sdk#7467 .

Updating deps to include this back ported fix. Hopefully this does not require re-updating all forks but trying locally now. Backporting the fix does require changing it from the tag to the branch.

4meta5 · 2025-02-12T15:29:35Z

Ok tried locally and need to update all forks to contain the fix. I think it is better to wait until they tag a release with this fix rather than forcing the updating on a branch.

Will post updates and monitor releases accordingly. Unfortunately the fix was not included in https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2412-1

4meta5 · 2025-02-13T15:45:32Z

Updating all forks now to use the commit that includes the fix. Once all forks are upgraded, will upgrade this template and create a follow up issue.

…e merged into pallet abstractions

4meta5 · 2025-02-17T15:46:44Z

@KitHat can you please merge your PR integrating DOT as fee changes into main and merge main into this branch. It will be faster to do than having me duplicate your work to configure your changes.

Here is the current error which is coming from not updating the generic template runtime to include the new required changes since the Oracle was included in pallet-abstractions:

  error: custom attribute panicked
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/apis.rs:23:1
     |
  23 | #[openzeppelin_runtime_apis]
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: message: Error while parsing assets config: "`type OracleKey` not specified, but required"

  error[E0432]: unresolved import `crate::Aura`
   --> /Users/4meta5/oz/templates/generic-template/runtime/src/apis.rs:4:5
    |
  4 | use crate::Aura;
    |     ^^^^^^^^^^^ no `Aura` in the root

  error[E0432]: unresolved imports `crate::InherentDataExt`, `crate::ParachainSystem`, `crate::Runtime`, `crate::RuntimeCall`, `crate::RuntimeGenesisConfig`, `crate::System`, `crate::TransactionPayment`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/apis.rs:15:5
     |
  15 |     InherentDataExt, ParachainSystem, Runtime, RuntimeBlockWeights, RuntimeCall,
     |     ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^  ^^^^^^^                       ^^^^^^^^^^^ no `RuntimeCall` in the root
     |     |                |                |
     |     |                |                no `Runtime` in the root
     |     |                no `ParachainSystem` in the root
     |     no `InherentDataExt` in the root
  16 |     RuntimeGenesisConfig, SessionKeys, System, TransactionPayment,
     |     ^^^^^^^^^^^^^^^^^^^^               ^^^^^^  ^^^^^^^^^^^^^^^^^^ no `TransactionPayment` in the root
     |     |                                  |
     |     |                                  no `System` in the root
     |     no `RuntimeGenesisConfig` in the root

  error[E0432]: unresolved imports `crate::AssetManager`, `crate::Assets`, `crate::Runtime`, `crate::RuntimeCall`, `crate::RuntimeOrigin`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/asset_config.rs:14:5
     |
  14 |     AssetManager, Assets, Runtime, RuntimeCall, RuntimeOrigin,
     |     ^^^^^^^^^^^^  ^^^^^^  ^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^^^^^^ no `RuntimeOrigin` in the root
     |     |             |       |        |
     |     |             |       |        no `RuntimeCall` in the root
     |     |             |       no `Runtime` in the root
     |     |             no `Assets` in the root
     |     no `AssetManager` in the root
     |
     = help: consider importing one of these items instead:
             crate::configs::Assets
             crate::configs::Response::Assets
             cumulus_primitives_core::Assets
             cumulus_primitives_core::Response::Assets
             xcm::opaque::latest::Assets
             xcm::opaque::latest::Response::Assets
             xcm::opaque::lts::Assets
             xcm::opaque::lts::Response::Assets
             xcm::opaque::v3::Response::Assets

  error[E0432]: unresolved import `crate::RuntimeOrigin`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/governance/mod.rs:10:5
     |
  10 |     RuntimeOrigin,
     |     ^^^^^^^^^^^^^ no `RuntimeOrigin` in the root

  error[E0432]: unresolved import `crate::Runtime`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/weight.rs:10:5
     |
  10 |     Runtime,
     |     ^^^^^^^ no `Runtime` in the root

  error[E0432]: unresolved imports `crate::configs::ParachainSystem`, `crate::configs::Runtime`, `crate::configs::RuntimeCall`, `crate::configs::XcmpQueue`, `crate::Assets`, `crate::Balances`, `crate::ParachainInfo`, `crate::PolkadotXcm`, `crate::RuntimeOrigin`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/xcm_config.rs:26:32
     |
  26 |     configs::{MaxInstructions, ParachainSystem, Runtime, RuntimeCall, UnitWeightCost, XcmpQueue},
     |                                ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^^^                  ^^^^^^^^^ no `XcmpQueue` in `configs`
     |                                |                |        |
     |                                |                |        no `RuntimeCall` in `configs`
     |                                |                no `Runtime` in `configs`
     |                                no `ParachainSystem` in `configs`
  27 |     types::{AccountId, AssetId, Balance, TreasuryAccount},
  28 |     Assets, Balances, ParachainInfo, PolkadotXcm, RuntimeOrigin,
     |     ^^^^^^  ^^^^^^^^  ^^^^^^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^^^^^^ no `RuntimeOrigin` in the root
     |     |       |         |              |
     |     |       |         |              no `PolkadotXcm` in the root
     |     |       |         no `ParachainInfo` in the root
     |     |       no `Balances` in the root
     |     no `Assets` in the root
     |
     = help: consider importing one of these items instead:
             crate::configs::Assets
             crate::configs::Response::Assets
             cumulus_primitives_core::Assets
             cumulus_primitives_core::Response::Assets
             xcm::opaque::latest::Assets
             xcm::opaque::latest::Response::Assets
             xcm::opaque::lts::Assets
             xcm::opaque::lts::Response::Assets
             xcm::opaque::v3::Response::Assets
     = note: unresolved item `crate::configs::tracks::RuntimeOrigin` exists but is inaccessible
  help: a similar name exists in the module
     |
  26 |     configs::{MaxInstructions, ParachainMinFee, Runtime, RuntimeCall, UnitWeightCost, XcmpQueue},
     |                                ~~~~~~~~~~~~~~~
  help: a similar name exists in the module
     |
  28 |     Assets, Balance, ParachainInfo, PolkadotXcm, RuntimeOrigin,
     |             ~~~~~~~

  error[E0432]: unresolved imports `crate::AllPalletsWithSystem`, `crate::AssetManager`, `crate::Balances`, `crate::MessageQueue`, `crate::OriginCaller`, `crate::PalletInfo`, `crate::ParachainInfo`, `crate::ParachainSystem`, `crate::PolkadotXcm`, `crate::Preimage`, `crate::Referenda`, `crate::Runtime`, `crate::RuntimeCall`, `crate::RuntimeEvent`, `crate::RuntimeFreezeReason`, `crate::RuntimeHoldReason`, `crate::RuntimeOrigin`, `crate::RuntimeTask`, `crate::Scheduler`, `crate::System`, `crate::Treasury`, `crate::XcmpQueue`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:85:5
     |
  85 |     AllPalletsWithSystem, AssetManager, Balances, MessageQueue, OriginCaller, PalletInfo,
     |     ^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^  ^^^^^^^^  ^^^^^^^^^^^^  ^^^^^^^^^^^^  ^^^^^^^^^^ no `PalletInfo` in the root
     |     |                     |             |         |             |
     |     |                     |             |         |             no `OriginCaller` in the root
     |     |                     |             |         no `MessageQueue` in the root
     |     |                     |             no `Balances` in the root
     |     |                     |             help: a similar name exists in the module: `Balance`
     |     |                     no `AssetManager` in the root
     |     no `AllPalletsWithSystem` in the root
  86 |     ParachainInfo, ParachainSystem, PolkadotXcm, Preimage, Referenda, Runtime, RuntimeCall,
     |     ^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^  ^^^^^^^^^  ^^^^^^^  ^^^^^^^^^^^
     |     |              |                |            |
     |     |              |                |            no `Preimage` in the root
     |     |              |                no `PolkadotXcm` in the root
     |     |              no `ParachainSystem` in the root
     |     no `ParachainInfo` in the root
  87 |     RuntimeEvent, RuntimeFreezeReason, RuntimeHoldReason, RuntimeOrigin, RuntimeTask, Scheduler,
     |     ^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^^
  88 |     System, Treasury, WeightToFee, XcmpQueue,
     |     ^^^^^^  ^^^^^^^^               ^^^^^^^^^
     |
     = help: consider importing one of these items instead:
             crate::configs::opaque::PalletInfo
             cumulus_primitives_core::PalletInfo
             frame_support::traits::PalletInfo
             xcm::opaque::latest::PalletInfo
             xcm::opaque::lts::PalletInfo
             xcm::opaque::v3::PalletInfo
     = help: consider importing this variant instead:
             pallet_preimage::HoldReason::Preimage

  error[E0432]: unresolved imports `crate::Aura`, `crate::CollatorSelection`, `crate::Session`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:91:13
     |
  91 | use crate::{Aura, CollatorSelection, Session};
     |             ^^^^  ^^^^^^^^^^^^^^^^^  ^^^^^^^ no `Session` in the root
     |             |     |
     |             |     no `CollatorSelection` in the root
     |             no `Aura` in the root

  error[E0432]: unresolved import `crate::Treasury`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/types.rs:29:5
     |
  29 |     Treasury,
     |     ^^^^^^^^ no `Treasury` in the root
     |
     = help: consider importing one of these variants instead:
             cumulus_primitives_core::BodyId::Treasury
             xcm::opaque::lts::BodyId::Treasury

  error[E0432]: unresolved imports `crate::AllPalletsWithSystem`, `crate::Runtime`, `crate::RuntimeCall`, `crate::XcmpQueue`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/types.rs:40:5
     |
  40 |     AllPalletsWithSystem, Runtime, RuntimeBlockWeights, RuntimeCall, XcmpQueue,
     |     ^^^^^^^^^^^^^^^^^^^^  ^^^^^^^                       ^^^^^^^^^^^  ^^^^^^^^^ no `XcmpQueue` in the root
     |     |                     |                             |
     |     |                     |                             no `RuntimeCall` in the root
     |     |                     no `Runtime` in the root
     |     no `AllPalletsWithSystem` in the root

  error[E0433]: failed to resolve: use of undeclared crate or module `pallet_membership`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/lib.rs:131:1
      |
  131 | #[openzeppelin_construct_runtime]
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `pallet_membership`
      |
      = note: this error originates in the attribute macro `openzeppelin_construct_runtime` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0412]: cannot find type `Assets` in the crate root
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in the crate root
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: consider importing one of these structs
      |
  2   + use crate::configs::opaque::Assets;
      |
  2   + use cumulus_primitives_core::Assets;
      |
  2   + use xcm::opaque::latest::Assets;
      |
  2   + use xcm::opaque::lts::Assets;
      |

  error[E0412]: cannot find type `OracleMembership` in this scope
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0412]: cannot find type `Oracle` in this scope
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0425]: cannot find value `RUNTIME_API_VERSIONS` in module `apis`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/constants.rs:34:17
     |
  34 |     apis: apis::RUNTIME_API_VERSIONS,
     |                 ^^^^^^^^^^^^^^^^^^^^ not found in `apis`

  error[E0412]: cannot find type `PolkadotXcm` in the crate root
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/types.rs:135:12
      |
  135 |     crate::PolkadotXcm,
      |            ^^^^^^^^^^^ not found in the crate root

  error[E0412]: cannot find type `Aura` in this scope
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/lib.rs:96:19
     |
  96 |         pub aura: Aura,
     |                   ^^^^ not found in this scope

  error[E0412]: cannot find type `Aura` in this scope
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/lib.rs:96:19
     |
  96 |         pub aura: Aura,
     |                   ^^^^ not found in this scope
     |
  help: you might be missing a type parameter
    --> /Users/4meta5/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/54a4ec0/substrate/primitives/runtime/src/traits/mod.rs:2071:19
     |
  207|         pub struct $name<Aura> {
     |                         ++++++

  error[E0412]: cannot find type `Runtime` in this scope
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/lib.rs:131:1
      |
  131 | #[openzeppelin_construct_runtime]
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
      |
      = note: this error originates in the attribute macro `openzeppelin_construct_runtime` (in Nightly builds, run with -Z macro-backtrace for more info)

  warning: unused imports: `AccountId`, `Balance`, `Block`, `Executive`, `Nonce`, `RuntimeBlockWeights`, `SessionKeys`, and `constants::VERSION`
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/apis.rs:13:5
     |
  13 |     constants::VERSION,
     |     ^^^^^^^^^^^^^^^^^^
  14 |     types::{AccountId, Balance, Block, Executive, Nonce},
     |             ^^^^^^^^^  ^^^^^^^  ^^^^^  ^^^^^^^^^  ^^^^^
  15 |     InherentDataExt, ParachainSystem, Runtime, RuntimeBlockWeights, RuntimeCall,
     |                                                ^^^^^^^^^^^^^^^^^^^
  16 |     RuntimeGenesisConfig, SessionKeys, System, TransactionPayment,
     |                           ^^^^^^^^^^^
     |
     = note: `#[warn(unused_imports)]` on by default

  warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/constants.rs:29:16
     |
  29 |     spec_name: create_runtime_str!("template-parachain"),
     |                ^^^^^^^^^^^^^^^^^^
     |
     = note: `#[warn(deprecated)]` on by default

  warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
    --> /Users/4meta5/oz/templates/generic-template/runtime/src/constants.rs:30:16
     |
  30 |     impl_name: create_runtime_str!("template-parachain"),
     |                ^^^^^^^^^^^^^^^^^^

  warning: use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
   --> /Users/4meta5/oz/templates/generic-template/runtime/src/constants.rs:2:18
    |
  2 | use sp_runtime::{create_runtime_str, Perbill};
    |                  ^^^^^^^^^^^^^^^^^^

  error[E0220]: associated type `AccountId` not found for `Runtime`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated type `AccountId` not found
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0220]: associated type `RuntimeCall` not found for `Runtime`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated type `RuntimeCall` not found
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0223]: ambiguous associated type
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: if there were a trait named `Example` with associated type `AssetId` implemented for `TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor>`, you could use the fully-qualified path
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:168:27
      |
  168 |                 asset_id: <TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor> as Example>::AssetId,
      |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  error[E0223]: ambiguous associated type
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: if there were a trait named `Example` with associated type `Balance` implemented for `TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor>`, you could use the fully-qualified path
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:169:22
      |
  169 |                 fee: <TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor> as Example>::Balance,
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  error[E0223]: ambiguous associated type
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: if there were a trait named `Example` with associated type `Balance` implemented for `TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor>`, you could use the fully-qualified path
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:170:23
      |
  170 |                 _tip: <TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor> as Example>::Balance,
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  error[E0223]: ambiguous associated type
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: if there were a trait named `Example` with associated type `LiquidityInfo` implemented for `TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor>`, you could use the fully-qualified path
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:171:25
      |
  171 |             ) -> Result<<TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor> as Example>::LiquidityInfo, sp_runtime::transaction_validity::TransactionValidityError> {
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  error[E0223]: ambiguous associated type
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: if there were a trait named `Example` with associated type `Balance` implemented for `TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor>`, you could use the fully-qualified path
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:202:32
      |
  202 |                 corrected_fee: <TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor> as Example>::Balance,
      |                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  error[E0223]: ambiguous associated type
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: if there were a trait named `Example` with associated type `Balance` implemented for `TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor>`, you could use the fully-qualified path
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:203:22
      |
  203 |                 tip: <TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor> as Example>::Balance,
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  error[E0223]: ambiguous associated type
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: if there were a trait named `Example` with associated type `LiquidityInfo` implemented for `TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor>`, you could use the fully-qualified path
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:204:23
      |
  204 |                 paid: <TxFeeFungiblesAdapter<Converter, FeeCreditor, TipCreditor> as Example>::LiquidityInfo,
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  error[E0046]: not all trait items implemented, missing: `Timestamp`, `AccountId`, `FungiblesToAccount`, `RootOperatorAccountId`, `AssetsToBlockAuthor`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:180:1
      |
  180 | impl AssetsConfig for OpenZeppelinRuntime {
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `Timestamp`, `AccountId`, `FungiblesToAccount`, `RootOperatorAccountId`, `AssetsToBlockAuthor` in implementation
      |
      = help: implement the missing item: `type Timestamp = /* Type */;`
      = help: implement the missing item: `type AccountId = /* Type */;`
      = help: implement the missing item: `type FungiblesToAccount = /* Type */;`
      = help: implement the missing item: `type RootOperatorAccountId = /* Type */;`
      = help: implement the missing item: `type AssetsToBlockAuthor = /* Type */;`

  error[E0433]: failed to resolve: use of undeclared type `Oracle`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared type `Oracle`
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0433]: failed to resolve: use of undeclared crate or module `pallet_asset_tx_payment`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `pallet_asset_tx_payment`
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0433]: failed to resolve: use of undeclared crate or module `orml_oracle`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `orml_oracle`
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0433]: failed to resolve: use of undeclared crate or module `pallet_membership`
     --> /Users/4meta5/oz/templates/generic-template/runtime/src/configs/mod.rs:203:1
      |
  203 | impl_openzeppelin_assets!(OpenZeppelinRuntime);
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `pallet_membership`
      |
      = note: this error originates in the macro `impl_openzeppelin_assets` (in Nightly builds, run with -Z macro-backtrace for more info)
  help: there is a crate or module with a similar name
     --> /Users/4meta5/.cargo/git/checkouts/openzeppelin-pallet-abstractions-3c997722f447c3c9/2643f7a/src/assets.rs:297:14
      |
  297 |         impl pallet_authorship::Config for Runtime {
      |              ~~~~~~~~~~~~~~~~~

  Some errors have detailed explanations: E0046, E0220, E0223, E0412, E0425, E0432, E0433.
  For more information about an error, try `rustc --explain E0046`.
  warning: `generic-runtime-template` (lib) generated 4 warnings
  error: could not compile `generic-runtime-template` (lib) due to 47 previous errors; 4 warnings emitted

init updating moonbeam deps wip

970a85a

4meta5 self-assigned this Jan 10, 2025

4meta5 mentioned this pull request Jan 10, 2025

Upgrade evm-template to polkadot-stable2412 #397

Draft

8 tasks

wip upgrading deps todo tanssi and debug orml weird errors

41e43ef

This comment was marked as resolved.

Sign in to view

fix deps and regenerate cargo lock post update

3153cc1

This comment was marked as resolved.

Sign in to view

4meta5 added priority: 3 We will resolve this first before everything else. dependencies Pull requests that update a dependency file labels Jan 12, 2025

This comment was marked as resolved.

Sign in to view

4meta5 added 4 commits January 16, 2025 14:25

update moonkit and dancekit

0a5fed9

Merge branch 'main' into amar-upgrade-generic-stable2412

468aa38

toml sort

4db27a8

update moonkit and dancekit deps to compile no std still more changes…

69e39a1

… required in pallet abstractions

4meta5 mentioned this pull request Jan 20, 2025

Upgrade to polkadot-stable2412 OpenZeppelin/openzeppelin-pallet-abstractions#65

Open

more fixes

bb1b74d

This comment was marked as resolved.

Sign in to view

4meta5 added 3 commits January 21, 2025 18:08

down to 2 errors xcm reserve provider trait impls not backwards compa…

94283ab

…tible

generic runtime compiles

8c3ca17

typos in comments

2966d02

4meta5 marked this pull request as ready for review January 21, 2025 23:25

This comment was marked as resolved.

Sign in to view

4meta5 requested a review from KitHat January 23, 2025 18:54

KitHat approved these changes Jan 29, 2025

View reviewed changes

4meta5 added 2 commits January 29, 2025 14:38

bump nightly toolchain used

906e7b3

update xcm transactor benchmarks to compile from moonbeam fork

ed67533

Merge branch 'main' into amar-upgrade-generic-stable2412

b02ae86

still not compiling

6451977

push with broken changes needs to be updated since oracle changes wer…

3d4c88e

…e merged into pallet abstractions

4meta5 added 3 commits February 17, 2025 22:16

into main

95e21a7

fix

64798c7

toml sort

3c704f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade generic-template to polkadot-stable2412 #401

Upgrade generic-template to polkadot-stable2412 #401

4meta5 commented Jan 10, 2025 •

edited

Loading

netlify bot commented Jan 10, 2025 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

KitHat commented Jan 29, 2025

4meta5 commented Feb 3, 2025 •

edited

Loading

4meta5 commented Feb 10, 2025

4meta5 commented Feb 12, 2025 •

edited

Loading

4meta5 commented Feb 12, 2025

4meta5 commented Feb 13, 2025

4meta5 commented Feb 17, 2025 •

edited

Loading

Upgrade generic-template to polkadot-stable2412 #401

Are you sure you want to change the base?

Upgrade generic-template to polkadot-stable2412 #401

Conversation

4meta5 commented Jan 10, 2025 • edited Loading

Repo/Forks to Upgrade

Local Changes TODO

Follow up(s)

netlify bot commented Jan 10, 2025 • edited Loading

✅ Deploy Preview for docs-oz-polkadot canceled.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

KitHat commented Jan 29, 2025

4meta5 commented Feb 3, 2025 • edited Loading

4meta5 commented Feb 10, 2025

4meta5 commented Feb 12, 2025 • edited Loading

4meta5 commented Feb 12, 2025

4meta5 commented Feb 13, 2025

4meta5 commented Feb 17, 2025 • edited Loading

4meta5 commented Jan 10, 2025 •

edited

Loading

netlify bot commented Jan 10, 2025 •

edited

Loading

4meta5 commented Feb 3, 2025 •

edited

Loading

4meta5 commented Feb 12, 2025 •

edited

Loading

4meta5 commented Feb 17, 2025 •

edited

Loading