Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toml-sort #69

Merged
merged 13 commits into from
Dec 21, 2023
Merged

Toml-sort #69

merged 13 commits into from
Dec 21, 2023

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Dec 19, 2023 •
edited
Loading

Closes #43

Adds value by enforcing alphabetic order for all dependencies in all Cargo.toml files. Alphabetic ordering of dependencies makes it easier to find them when manually adding/removing/replacing for dependency upgrades.

Completed Tasks

  • run toml-sort (all Cargo.toml changes are generated from running ./scripts/toml-sort.sh)
  • add script for running toml-sort which tells user to install it if it's not installed
  • incorporate toml-sort into the CI

@4meta5 4meta5 added the enhancement New feature or request label Dec 19, 2023
@4meta5 4meta5 self-assigned this Dec 19, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 19, 2023 •
edited
Loading

✅ Deploy Preview for docs-oz-polkadot canceled.

Name Link
🔨 Latest commit 9597606
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/65836a92a0a8b7000874095f

@4meta5 4meta5 added the CI devops label Dec 20, 2023
@4meta5 4meta5 marked this pull request as ready for review December 20, 2023 04:05
ozgunozerk
ozgunozerk approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ozgunozerk ozgunozerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

KitHat
KitHat approved these changes Dec 20, 2023
View reviewed changes
.github/workflows/cargo-tests.yml Show resolved Hide resolved
@ozgunozerk
Copy link
Collaborator

and please use squash-merge

@4meta5 4meta5 mentioned this pull request Dec 20, 2023
Open
@4meta5 4meta5 enabled auto-merge (squash) December 20, 2023 21:16
@4meta5 4meta5 disabled auto-merge December 20, 2023 21:27
@4meta5 4meta5 merged commit 7d53d4f into main Dec 21, 2023
5 checks passed
@4meta5 4meta5 deleted the amar-toml-sort branch December 21, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitHat KitHat KitHat approved these changes

@ozgunozerk ozgunozerk ozgunozerk approved these changes

Assignees

@4meta5 4meta5

Labels
CI devops enhancement New feature or request
Projects
Substrate Runtime Templates
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format Cargo.toml dependencies alphabetically via toml-sort
3 participants
@4meta5 @ozgunozerk @KitHat