address feedback

Opentrons · Jan 15, 2025 · 5ea4660 · 5ea4660
1 parent 9feee26
commit 5ea4660
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/components/src/atoms/MenuList/index.tsx b/components/src/atoms/MenuList/index.tsx
@@ -29,6 +29,7 @@ export const MenuList = forwardRef<HTMLDivElement, MenuListProps>(
       top = '2.6rem',
       right = `calc(50% + ${SPACING.spacing4})`,
       width = FLEX_MAX_CONTENT,
+      zIndex = 10,
       ...restProps
     } = props
     return isOnDevice ? (
@@ -48,7 +49,7 @@ export const MenuList = forwardRef<HTMLDivElement, MenuListProps>(
     ) : (
       <Flex
         borderRadius={BORDERS.borderRadius8}
-        zIndex={12}
+        zIndex={zIndex}
         boxShadow="0px 1px 3px rgba(0, 0, 0, 0.2)"
         position={POSITION_ABSOLUTE}
         backgroundColor={COLORS.white}

diff --git a/protocol-designer/src/pages/Designer/LiquidsOverflowMenu.tsx b/protocol-designer/src/pages/Designer/LiquidsOverflowMenu.tsx
@@ -14,7 +14,6 @@ import {
   MenuItem,
   MenuList,
   OVERFLOW_AUTO,
-  POSITION_ABSOLUTE,
   SPACING,
   StyledText,
   TYPOGRAPHY,
@@ -44,7 +43,6 @@ export function LiquidsOverflowMenu(
   const dispatch: ThunkDispatch<any> = useDispatch()
   return (
     <MenuList
-      position={POSITION_ABSOLUTE}
       zIndex={12}
       right={location.pathname === '/liquids' ? SPACING.spacing12 : '3.125rem'}
       top={`calc(${NAV_HEIGHT} - 6px)`}

diff --git a/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepOverflowMenu.tsx b/protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepOverflowMenu.tsx
@@ -94,6 +94,7 @@ export function StepOverflowMenu(props: StepOverflowMenuProps): JSX.Element {
   return (
     <>
       <MenuList
+        zIndex={12}
         ref={menuRootRef}
         top={top}
         left="18.75rem"