fix(app): fix post run tip detection after error recovery (#16860)

Closes RQA-3589

It's insufficient to check if a run entered error recovery as the sole condition for whether or not to run the post-run drop tip wizard, because it's possible for a run to proceed through error recovery then encounter a terminal error. In these spots, we must show drop tip wizard.

To fix, determine whether the run just entered error recovery (or not). If it didn't, do the tip detection logic.

app/src/local-resources/commands/utils/index.ts

@@ -1 +1,2 @@
 export * from './getCommandTextData'
+export * from './lastRunCommandPromptedErrorRecovery'

app/src/local-resources/commands/utils/lastRunCommandPromptedErrorRecovery.ts

@@ -0,0 +1,13 @@
+import type { RunCommandSummary } from '@opentrons/api-client'
+
+// Whether the last run protocol command prompted Error Recovery.
+export function lastRunCommandPromptedErrorRecovery(
+  summary: RunCommandSummary[]
+): boolean {
+  const lastProtocolCommand = summary.findLast(
+    command => command.intent !== 'fixit' && command.error != null
+  )
+
+  // All recoverable protocol commands have defined errors.
+  return lastProtocolCommand?.error?.isDefined ?? false
+}

app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/hooks/useRunHeaderDropTip.ts

@@ -9,8 +9,13 @@ import {
   useTipAttachmentStatus,
 } from '/app/organisms/DropTipWizardFlows'
 import { useProtocolDropTipModal } from '../modals'
-import { useCloseCurrentRun, useIsRunCurrent } from '/app/resources/runs'
+import {
+  useCloseCurrentRun,
+  useCurrentRunCommands,
+  useIsRunCurrent,
+} from '/app/resources/runs'
 import { isTerminalRunStatus } from '../../utils'
+import { lastRunCommandPromptedErrorRecovery } from '/app/local-resources/commands'
 
 import type { RobotType } from '@opentrons/shared-data'
 import type { Run, RunStatus } from '@opentrons/api-client'
@@ -102,6 +107,15 @@ export function useRunHeaderDropTip({
       : { showDTWiz: false, dtWizProps: null }
   }
 
+  const runSummaryNoFixit = useCurrentRunCommands(
+    {
+      includeFixitCommands: false,
+      pageLength: 1,
+      cursor: null,
+    },
+    { enabled: isTerminalRunStatus(runStatus) }
+  )
+
   // Manage tip checking
   useEffect(() => {
     // If a user begins a new run without navigating away from the run page, reset tip status.
@@ -111,11 +125,14 @@ export function useRunHeaderDropTip({
       }
       // Only determine tip status when necessary as this can be an expensive operation. Error Recovery handles tips, so don't
       // have to do it here if done during Error Recovery.
-      else if (isTerminalRunStatus(runStatus) && !enteredER) {
+      else if (
+        runSummaryNoFixit != null &&
+        !lastRunCommandPromptedErrorRecovery(runSummaryNoFixit)
+      ) {
         void determineTipStatus()
       }
     }
-  }, [runStatus, robotType, enteredER])
+  }, [runStatus, robotType, runSummaryNoFixit])
 
   // TODO(jh, 08-15-24): The enteredER condition is a hack, because errorCommands are only returned when a run is current.
   // Ideally the run should not need to be current to view errorCommands.

app/src/organisms/DropTipWizardFlows/hooks/useTipAttachmentStatus/getPipettesWithTipAttached.ts

@@ -63,7 +63,12 @@ function getCommandsExecutedDuringRun(
   })
 }
 
-const TIP_EXCHANGE_COMMAND_TYPES = ['dropTip', 'dropTipInPlace', 'pickUpTip']
+const TIP_EXCHANGE_COMMAND_TYPES = [
+  'dropTip',
+  'dropTipInPlace',
+  'pickUpTip',
+  'moveToAddressableAreaForDropTip',
+]
 
 function checkPipettesForAttachedTips(
   commands: RunCommandSummary[],

app/src/pages/ODD/RunSummary/index.tsx

@@ -65,11 +65,13 @@ import {
   useRunCreatedAtTimestamp,
   useCloseCurrentRun,
   EMPTY_TIMESTAMP,
+  useCurrentRunCommands,
 } from '/app/resources/runs'
 import {
   useTipAttachmentStatus,
   handleTipsAttachedModal,
 } from '/app/organisms/DropTipWizardFlows'
+import { lastRunCommandPromptedErrorRecovery } from '/app/local-resources/commands'
 
 import type { IconName } from '@opentrons/components'
 import type { OnDeviceRouteParams } from '/app/App/types'
@@ -238,11 +240,21 @@ export function RunSummary(): JSX.Element {
   })
 
   // Determine tip status on initial render only. Error Recovery always handles tip status, so don't show it twice.
+  const runSummaryNoFixit = useCurrentRunCommands({
+    includeFixitCommands: false,
+    pageLength: 1,
+    cursor: null,
+  })
   useEffect(() => {
-    if (isRunCurrent && enteredER === false) {
+    if (
+      isRunCurrent &&
+      runSummaryNoFixit != null &&
+      !lastRunCommandPromptedErrorRecovery(runSummaryNoFixit)
+    ) {
+      console.log('HITTING THIS')
       void determineTipStatus()
     }
-  }, [isRunCurrent, enteredER])
+  }, [runSummaryNoFixit, isRunCurrent])
 
   const returnToQuickTransfer = (): void => {
     closeCurrentRunIfValid(() => {