Skip to content

Commit

Permalink
chore(app-shell): pass team id via env var only (#17210)
Browse files Browse the repository at this point in the history
This is very odd and I'm not sure when it would have changed but this is
the thing the error message says to do.

## Testing
- [x] does the apple build work
- [x] does the apple build run
  • Loading branch information
sfoster1 authored Jan 8, 2025
1 parent cff47c9 commit b565fea
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions app-shell/electron-builder.config.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
'use strict'
const path = require('path')

const {
OT_APP_DEPLOY_BUCKET,
OT_APP_DEPLOY_FOLDER,
APPLE_TEAM_ID,
} = process.env
const { OT_APP_DEPLOY_BUCKET, OT_APP_DEPLOY_FOLDER } = process.env
const DEV_MODE = process.env.NODE_ENV !== 'production'
const USE_PYTHON = process.env.NO_PYTHON !== 'true'
const WINDOWS_SIGN = process.env.WINDOWS_SIGN === 'true'
Expand Down Expand Up @@ -62,9 +58,7 @@ module.exports = async () => ({
icon: project === 'robot-stack' ? 'build/icon.icns' : 'build/three.icns',
forceCodeSigning: !DEV_MODE,
gatekeeperAssess: true,
notarize: {
teamId: APPLE_TEAM_ID,
},
// note: notarize.teamId is passed by implicitly sending through the APPLE_TEAM_ID env var
},
dmg: {
icon: null,
Expand Down

0 comments on commit b565fea

Please sign in to comment.