Skip to content

Commit

Permalink
refactor(robot-server): use different pipette IDs for OT2 vs Flex dev…
Browse files Browse the repository at this point in the history
… servers (#17031)

# Overview

The OT2 and Flex pipette calibration data format is slightly different.
In the simulator setup file, we have the OT2 & Flex pipette IDs the same
so the calibration files get unintentionally shared between OT2 & Flex.
When switching between OT2 and Flex dev servers, the difference in data
format causes a validation error and we have to re-calibrate the
pipettes (or update the files) each time. It's quite annoying to have to
do this so I am changing the Flex's pipette ID so that we'll be able to
use separate calibration files for flex & OT2 pipettes.

## Risk assessment

None. Dev server change only
  • Loading branch information
sanni-t authored Dec 4, 2024
1 parent 607e119 commit bce6cd0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ async def _wait_for_event(self) -> None:
f'PublisherNotifier: exception in callback {getattr(callback, "__name__", "<unknown>")}'
)
except asyncio.exceptions.CancelledError:
LOG.warning("PublisherNotifuer task cancelled.")
LOG.warning("PublisherNotifier task cancelled.")
except BaseException:
LOG.exception("PublisherNotifer notify task failed")
LOG.exception("PublisherNotifier notify task failed")


_pe_publisher_notifier_accessor: AppStateAccessor[PublisherNotifier] = AppStateAccessor[
Expand Down
6 changes: 3 additions & 3 deletions robot-server/simulators/test-flex.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
"attached_instruments": {
"right": {
"model": "p1000_single_3.4",
"id": "321"
"id": "321_flex"
},
"left": {
"model": "p50_single_3.4",
"id": "123"
"id": "123_flex"
},
"gripper":{
"model": "gripper_1.3",
"id": "1234"
"id": "1234_flex_gripper"
}
},
"attached_modules": {
Expand Down

0 comments on commit bce6cd0

Please sign in to comment.