-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(monorepo): migrate frontend bundling from webpack to vite #14405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14405 +/- ##
==========================================
- Coverage 67.50% 67.47% -0.03%
==========================================
Files 2514 2484 -30
Lines 72376 71319 -1057
Branches 9317 9084 -233
==========================================
- Hits 48857 48125 -732
+ Misses 21314 21039 -275
+ Partials 2205 2155 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
57c9e95
to
dab10da
Compare
…m:Opentrons/opentrons into protocol_designer-migrate-webpack-to-vite
…ithub.com/Opentrons/opentrons into protocol_designer-migrate-webpack-to-vite
…ithub.com/Opentrons/opentrons into protocol_designer-migrate-webpack-to-vite
…ithub.com/Opentrons/opentrons into protocol_designer-migrate-webpack-to-vite
…ithub.com/Opentrons/opentrons into protocol_designer-migrate-webpack-to-vite
…ithub.com/Opentrons/opentrons into protocol_designer-migrate-webpack-to-vite
mjhuff
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
migrate frontend bundler from webpack to vite Co-authored-by: Jamey Huffnagle <[email protected]> Co-authored-by: Brian Cooper <[email protected]> Co-authored-by: koji <[email protected]> Co-authored-by: Jethary <[email protected]> Co-authored-by: ncdiehl11 <[email protected]> Co-authored-by: smb2268 <[email protected]> Co-authored-by: Brent Hagen <[email protected]>
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
migrate frontend bundler from webpack to vite Co-authored-by: Jamey Huffnagle <[email protected]> Co-authored-by: Brian Cooper <[email protected]> Co-authored-by: koji <[email protected]> Co-authored-by: Jethary <[email protected]> Co-authored-by: ncdiehl11 <[email protected]> Co-authored-by: smb2268 <[email protected]> Co-authored-by: Brent Hagen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
Test Plan
Because this PR is so massive, the best way to test this is to smoke test:
Changelog
Review requests
This PR is massive so it's not going to be a good use of time to go through every file change. Important ones to review though:
Risk assessment
on a scale from 1-10 probably like a 47