fix(hardware_control): Fixing liquid probe bugs found in end to end testing #15619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
sfoster1
previously requested changes
Jul 10, 2024
SyntaxColoring
requested changes
Jul 10, 2024
…ad of returning False
ryanthecoder
commented
Jul 12, 2024
…capture (#15629) This PR is an automated snapshot update request. Please review the changes and merge if they are acceptable or find your bug and fix it. Co-authored-by: aaron-kulkarni <[email protected]>
ryanthecoder
commented
Jul 15, 2024
SyntaxColoring
approved these changes
Jul 15, 2024
Comment on lines
-102
to
-107
| current_well = CurrentWell( | ||
| pipette_id=pipette_id, | ||
| labware_id=labware_id, | ||
| well_name=well_name, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Ah, yep, that'd do it. Nice catch.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #15619 +/- ##
=======================================
Coverage 60.12% 60.12%
=======================================
Files 190 190
Lines 10627 10627
=======================================
Hits 6390 6390
Misses 4237 4237
Flags with carried forward coverage won't be shown. Click here to find out more. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
These changes came from testing the end to end implementation of liquid level detection on the ot3 and fixing the bugs that came up.
Test Plan
Changed the unit tests to match new functionality.
Tested all new methods for liquid level detection on the ot3.
Changelog
Changes include:
Review requests
We are aware of a bug that even though we handle LLD exceptions at the protocol_context level, protocol_engine commands will still be marked as failed, so all future commands will fail. As far as I know for this PR, this only affects detect_liquid_presence on a well with no liquid. Another PR will be coming soon that addresses this.
Risk assessment
Medium? I'm not sure.