-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-engine): Add tryLiquidProbe to complement liquidProbe #15667
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f921422
Minor liquidProbe command fixups.
SyntaxColoring 47515f4
Add tryLiquidProbe models and implementation.
SyntaxColoring 8135224
Update command unions.
SyntaxColoring fe9c620
Minor liquidProbe unit test fixups.
SyntaxColoring 03a345f
Update liquidProbe/tryLiquidProbe unit tests.
SyntaxColoring 8cde701
Update command schema 8.
SyntaxColoring 2ff9417
Merge branch 'edge' into second_probe_command
SyntaxColoring 3de025e
Merge branch 'edge' into second_probe_command
SyntaxColoring 2bb37c1
Add re-exports.
SyntaxColoring 2efe96a
Add a separate params type.
SyntaxColoring File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names
liquidProbe
/tryLiquidProbe
are inconsistent withverifyTipPresence
/getTipPresence
. I really don't know what to do about this at this point, since it seems like it'd be annoying to renameliquidProbe
, but I'm open to ideas.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be annoying? I don't think anybody uses it right now. I think we could do either
VerifyLiquidPresence
/GetLiquidPresence
, if we want to add a distinct command for get liquid heightLiquidProbe
,VerifyLiquidPresence
seems like a good standalone command name honestly. Probably would want its own file though.