-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update vite version 5.3.2 #15739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update vite version
koji
requested review from
smb2268,
a team and
TamarZanzouri
and removed request for
a team,
smb2268 and
TamarZanzouri
August 8, 2024 23:25
koji
requested review from
sfoster1,
smb2268,
brenthagen,
ncdiehl11,
mjhuff and
jerader
September 27, 2024 15:50
koji
changed the title
chore: update vite version 5.4.8
chore: update vite version 5.3.2
Sep 30, 2024
sfoster1
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - let's merge and get some builds out and tested. we can always revert if we need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update vite version v5.3.2 and shx to v0.3.4
close AUTH-575
PD is using a few packages that have issues with
mjs
. This will be fixed in the future.ToDo
update plugins
check make commands
cjs
https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
vite.config.ts -> vite.config.mts
https://opentrons.slack.com/archives/C6PF2M2LC/p1721746824847409
For vitest, the required updates will be done another PR, #15687
bonus
we can use a VSCode plugin to run test code from VSCode
Test Plan
when you run a project, there is no waring message except for
protocol-designer
Changelog
Review requests
Risk assessment
should be low