Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Merge changes from v7.4.0 into edge #15773

Merged
merged 7 commits into from
Jul 23, 2024
Merged

chore(release): Merge changes from v7.4.0 into edge #15773

merged 7 commits into from
Jul 23, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Jul 23, 2024

v7.4.0 into edge

This is a unique one, only 1193c29 is not already in edge so doing it directly without a collaborative PR and then pushing.

Edit - need to resolve conflict, will just git checkout edge -- app-shell/scripts/windows-custom-sign.js

Have approval on this PR then:

git switch release && git pull
git switch edge && git pull
git merge --no-ff  release
git checkout edge -- app-shell/scripts/windows-custom-sign.js
git add .
git status
git commit -m 'chore(release): Merge changes from v7.4.0 into edge'
git status
git log --oneline --decorate --graph -n10
git push origin edge

When you run this merge the only files that change are:

  • api/release-notes.md
  • app-shell/build/release-notes.md

vegano1 and others added 7 commits June 18, 2024 13:50
# Overview

Indicate that 7.4.0 adds support for HEPA/UV.

# Test Plan

Check in-app after alpha 0 tag is cut.

# Changelog

app-shell and api notes.

# Risk assessment

nil
## `cherry-pick` 246efcb

Must update `chore_release-7.4.0` so that windows builds work and we may
test an update. To understand the changes see #15718

Co-authored-by: Seth Foster <[email protected]>
…5741)

## `cherry-pick` afaa717

Must update `chore_release-7.4.0` so that Linux app builds work due to a
change in setuptools. To understand the changes see #15717

Co-authored-by: Ryan Howard <[email protected]>
…ip install (#15624)

## Replaces #15618 with PR against branch name ending in
`app-build-internal` to trigger a build

## Overview

- <https://opentrons.atlassian.net/browse/RQA-2830>
- `macos-11` GitHub runner was intel and now we use macos-latest that is
arm
[doc](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories)
- specify --x64 argument to electron-builder
- ~~per
[doc](https://github.com/actions/setup-python?tab=readme-ov-file#supported-architectures)
x64 python should be installed so the pip install will be the right
platform. I'm not confident in this.~~
- see comment in #15618
- we need to use the python we download on mac to do the pip install so
the installed packages match the platform correctly

## Test Plan

- [x] build locally and see that it works
- [x] watch CI and install the built package
- [x] validate that once the package dmg is x64 that analysis works
(python has packages with the right arch)

# Review requests

- This the right approach?

# Risk assessment

High because our .dmg currently cannot analyze protocols 2.0.0-alpha.0
internal release build.
@y3rsh y3rsh self-assigned this Jul 23, 2024
@y3rsh y3rsh requested review from a team as code owners July 23, 2024 20:10
@y3rsh y3rsh requested review from jerader and removed request for a team July 23, 2024 20:10
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@y3rsh y3rsh merged commit ac8ec1a into edge Jul 23, 2024
197 of 203 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants