feat(api): Handle overpressures in AspirateInPlace, DispenseInPlace #15791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use DefinedErrorData for pipette overpressures in AspirateInPlace. This is mostly similar to adding the same handling for Aspirate and Dispense, but the big difference is that these commands are not associated with wells or with points via their params. We get the current point by asking the hardware where it is; it's important to do this rather than getting it from the state because someone could conceivably have called AspirateInPlace as the first command after a move command with a different pipette, and we wouldn't have the point in state. We don't get the current well at all. That's because this command isn't associated with a well, so there's not really anything to change. Closes EXEC-496
sfoster1
changed the title
|
Tested on a robot and it does seem to work! |
SyntaxColoring
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use DefinedErrorData for pipette overpressures in AspirateInPlace and DispenseInPlace.
This is mostly similar to adding the same handling for Aspirate and Dispense, but the big difference is that these commands are not associated with wells or with points via their params.
We get the current point by asking the hardware where it is; it's important to do this rather than getting it from the state because someone could conceivably have called AspirateInPlace/DispenseInPlace as the first command after a move command with a different pipette, and we wouldn't have the point in state.
We don't get the current well at all. That's because this command isn't associated with a well, so there's not really anything to change.
Closes EXEC-496
Closes EXEC-622
Testing