refactor(api): Port touchTip, liquidProbe, and tryLiquidProbe location updates to StateUpdate
#16261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No need for two whole separate functions that only differ in the get_is_ready_to_aspirate() mock's return value, especially when the subject ignores that return value. * Remove a redundant verify().
| well_location=params.wellLocation, | ||
| ) | ||
| except PipetteLiquidNotFoundError as e: | ||
| return e, state_update, deck_point |
There was a problem hiding this comment.
if its ok can we return a data model instead of a tuple? I find it confusing that the first arg can be an error/z pos
There was a problem hiding this comment.
I'm using a NamedTuple now, which is a little better, but I'm still cramming a float and Exception into a single attribute, which sounds like the real point of confusion.
I think I'd like to keep that as-is for type safety reasons. There will always either be a "no liquid found" condition with exception details, or there will be a z_pos, so I'd rather represent that in the type system than use asserts or whatever. I do see your point about it being confusing when two totally different things are in a single attribute.
TamarZanzouri
requested changes
Sep 16, 2024
TamarZanzouri
approved these changes
Sep 17, 2024
SyntaxColoring
added a commit
that referenced
this pull request
Sep 18, 2024
## Overview A trivial refactor as part of EXEC-652. ## Changelog The `DefinedErrorData.private` attribute was obsoleted by PR #16160's `StateUpdate` mechanism. PR #16261 deleted the last use of it, so we can delete the attribute now. `DefinedErrorData`'s sibling class, `SuccessData`, also has an identical `private` attribute. We're not quite ready to delete that one, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
More incremental work towards EXEC-652.
Test Plan and Hands on Testing
Changelog
This continues the pattern started in #16160. The following commands now use the new
StateUpdatemechanism to update the pipette's logical state for the purposes of path planning:touchTipliquidProbetryLiquidProbeReview requests
Double-check that the behavior of the code that I'm removing from
PipetteStoreis exactly preserved by the code I'm adding toTouchTipImplementation,LiquidProbeImplementation, andTryLiquidProbeImplementation.Risk assessment
Medium.