refactor(app): Untangle labware organisms #16295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new container for desktop-specific organisms. Also, there were a bunch of pictures of ~spider-man~ labware in here that could go in assets/ instead.
There were a couple helpers and types that lived in app/src/pages/Desktop/Labware that were imported all over the place in organisms. Let's give them a new home: local-resources In the same way that resources/ provides app-specific wrappers around robot api concerns, local-resources/ provides app-specific wrappers around code and handling of other opentrons resources, like (for now) labware.
sfoster1
force-pushed
the
untangle-labware-organisms
branch
from
5592402 to
9e4b034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another in the vein of the app code reorganization PRs. This time, take the organisms that make up the labware page and move them into an
organisms/Desktop/Labwaredirectory (which will eventually mirrororganisms/Desktop/Devices, since there's alreadyorganisms/Devices) as a new home.Also, get rid of the things they import from
pages/Desktop/Labwareby moving them to a new home:local-resources.In the same way that resources/ provides app-specific wrappers around robot api concerns, local-resources/ provides app-specific wrappers around code and handling of other opentrons resources, like (for now) labware.