feat(protocol-designer): move labware tools wire up #16314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
shlokamin,
koji and
ncdiehl11
and removed request for
a team
koji
reviewed
Sep 20, 2024
koji
reviewed
Sep 20, 2024
protocol-designer/src/molecules/CheckboxStepFormField/index.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Sep 20, 2024
protocol-designer/src/molecules/CheckboxStepFormField/index.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Sep 20, 2024
...rc/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLabwareTools/LabwareLocationField.tsx
Show resolved
Hide resolved
koji
reviewed
Sep 20, 2024
koji
reviewed
Sep 20, 2024
koji
reviewed
Sep 23, 2024
| labwareName: labwareDisplayName, | ||
| slot: locationString, | ||
| }) | ||
| : undefined |
There was a problem hiding this comment.
technically we can set undefined but errorToShow can be null so I think set null would be better since sometimes undefined causes an unexpected bug.
Suggested change
| : undefined | |
| : null |
There was a problem hiding this comment.
i'll fix this in my pr that i have been working on top of this pr!
koji
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-808
Overview
Wires up the move labware tools. It doesn't display any errors yet and doesn't hover over anything on the deck map yet.
Test Plan and Hands on Testing
Create a move labware step. for the flex, the gripper checkbox should appear. for an ot-2 the gripper checkbox should not appear. if you have a gripper attached, the checkbox is clickable. otherwise, the checkbox is disabled. This should mirror old PD interactions
Changelog
MoveLabwareToolsand create the check box and dropdown fieldsRisk assessment
low