fix(protocol-designer): fix the slot information cutoff issue #16323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify viewBox of deck view close RQA-3187
|
is the slot above A1 slightly cut off now? judging by the screenshots in your PR description 🤔 but the button looks like enough clearance to me! |
i think answer is no
|
|
also fix text alignment
|
jerader
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
modify
viewBoxof deck viewbefore
after
close RQA-3187
Test Plan and Hands on Testing
import the attached protocol and click edit protocol button in protocol overview
PD_deck_test.json.zip
Changelog
Review requests
Do you think we should modify viewBox more?
Risk assessment
low