feat(protocol-designer): wire up substeps for transfer and mix #16383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
changed the title
jerader
requested review from
koji and
ncdiehl11
and removed request for
a team and
brenthagen
koji
reviewed
Oct 1, 2024
protocol-designer/src/assets/localization/en/protocol_steps.json
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 1, 2024
koji
reviewed
Oct 1, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/MultichannelSubstep.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 1, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/MultichannelSubstep.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 1, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/PipettingSubsteps.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 1, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/Substep.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 1, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/Substep.tsx
Outdated
Show resolved
Hide resolved
jerader
force-pushed
the
pd_substeps-wireup
branch
from
96b0d0b to
8627016
Compare
koji
reviewed
Oct 1, 2024
| {t('shared:done')} | ||
| </PrimaryButton> | ||
| } | ||
| height="calc(100vh - 64px)" |
There was a problem hiding this comment.
do you think it is possible to avoid using vh here?
There was a problem hiding this comment.
all the toolboxes use vh 😬 i made a ticket to refactor all of them
koji
reviewed
Oct 1, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/SubstepsToolbox.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-854 AUTH-824 AUTH-804
Overview
Not really blocked by anything but would be good to rebase off of #16378 after it merges in
Wires up the substep details for pipetting steps (mix and transfer) and adds the labware labels to the deck when you're hovering over a step
Designs for this aren't quite finalized so we will probably have to go back and refine things
A follow up is to add test coverage: https://opentrons.atlassian.net/browse/AUTH-884
Test Plan and Hands on Testing
Create a flex or ot-2 protocol and add a mix step and a transfer step. To add a mix step, you'll have to turn off the redesign ff and make it through old PD
To access the step details, hit the timeline step overflow menu button and select "view details". It should only be a button available for transfer, mix and thermocycler steps. Note that the thermocycler details are not wired up yet.
Changelog
substeptoolboxcomponent and make components for single channel, multi channel, and thermocycler (which will be wired up separately)Risk assessment
low