fix(hardware,api): remove hardware import from simulate #17043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentrons_simulate was importing from opentrons_hardware via the hardware controller protocol interface, which was doing it to support sensor data queue spying. Fixing this required a pretty big refactor to make the link between the controller and opentrons_hardware be a callback that could reformat data, so we can make versions of the relevant firmware binding types that are safe for reexport. This work should be extended to the capacitive sensor queue at some point. Closes RQA-3766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opentrons_simulate was importing from opentrons_hardware via the hardware controller protocol interface, which was doing it to support sensor data queue spying.
Fixing this required a pretty big refactor to make the link between the controller and opentrons_hardware be a callback that could reformat data, so we can make versions of the relevant firmware binding types that are safe for reexport.
This work should be extended to the capacitive sensor queue at some point.
Closes RQA-3766