feat(modules): request reset reason on module connection #17052
Merged
+69
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
approved these changes
Dec 6, 2024
2 tasks
sfoster1
added a commit
that referenced
this pull request
Dec 10, 2024
These errors should not cause the system to fail in that way;. #17052 introduced using M114 to poll modules for their reset reason when they connect. But if the module doesn't know about that gcode because it hasn't been updated, it will fail, and if it fails while the server is starting (because the module is plugged in at boot), the server won't start. ## todo - [x] fix lint - [x] test on hw Closes RQA-3787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Python counterpart to Opentrons/opentrons-modules#485 . Now that modules are able to report the reason for their last reset using the HAL's RCC flags, we should request it every time we find a new module connection.
Changelog
For thermocycler, heater shaker, and temp deck drivers:
GET_RESET REASONgcode messageget_device_info, also send a request for the reset reason