Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fix dropdownmenu expand direction #17055

Merged
merged 4 commits into from
Dec 6, 2024
Merged

fix(components): fix dropdownmenu expand direction #17055

merged 4 commits into from
Dec 6, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 6, 2024

Overview

update handlePositionCalculation to solve the issue.

close RQA-3771

Test Plan and Hands on Testing

Changelog

Review requests

medium

Risk assessment

@alexjoel42
Copy link
Contributor

Screenshot 2024-12-06 at 11 53 38 AM

@alexjoel42
Copy link
Contributor

After moving a labware, the labware's location stops being tracked between modules (1).json

Protocol I used

@koji
Update index.tsx
b10ae20 
fix linting errors
jerader
jerader approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well on my end. I smoke tested every PD usage of DropdownMenu and everything is looking good!

@koji koji marked this pull request as ready for review December 6, 2024 18:14
@koji koji requested a review from a team as a code owner December 6, 2024 18:14
@koji koji requested review from mjhuff and removed request for a team December 6, 2024 18:14
@jerader
Copy link
Collaborator

jerader commented Dec 6, 2024

nice!

Screen.Recording.2024-12-06.at.13.15.50.mov

@koji koji added the authorship label Dec 6, 2024
@koji koji requested review from ncdiehl11 and removed request for mjhuff December 6, 2024 18:36
@koji koji merged commit 5c411b6 into chore_release-pd-8.2.0 Dec 6, 2024
62 checks passed
@koji koji deleted the fix_dropdown-expand-direction-issue branch December 6, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koji @alexjoel42 @jerader