Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol-designer): remove unused vite from package.json #17108

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 13, 2024

Overview

remove unused vite and plugin from package.json

actually pd is using 5.3.2 which is installed via root package.json and there is no reason to use v5.0.5 for pd

make -C protocol-designer dev
vite serve
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
Port 5178 is in use, trying another one...

  VITE v5.3.2  ready in 658 ms

  ➜  Local:   http://localhost:5179/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
  • make -C protocol-designer dev
  • make -C protocol-designer build
    build files work with a local server

Test Plan and Hands on Testing

  1. clone this branch
  2. make teardown-js && make setup-js
  3. run pd and build pd

Changelog

Review requests

Risk assessment

low

remove unused vite and plugin from package.json
@koji koji requested review from ncdiehl11 and jerader December 13, 2024 18:19
@koji koji marked this pull request as ready for review December 13, 2024 18:19
@koji koji requested a review from a team as a code owner December 13, 2024 18:19
@koji koji removed the request for review from a team December 13, 2024 18:31
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me to remove it. i'm curious why we added it to PD's package.json in the first place

@koji
Copy link
Contributor Author

koji commented Dec 13, 2024

this makes sense to me to remove it. i'm curious why we added it to PD's package.json in the first place

i think @shlokamin knows the answer.

@koji koji merged commit d6e5a5e into edge Dec 13, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants