chore(app): extend props of intervention modal #17533
Merged
+72
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamarZanzouri
requested review from
ncdiehl11,
sfoster1 and
smb2268
and removed request for
a team and
ncdiehl11
sfoster1
requested changes
Feb 14, 2025
app/src/molecules/InterventionModal/InterventionContent/InterventionInfo.tsx
Outdated
Show resolved
Hide resolved
sfoster1
requested changes
Feb 18, 2025
app/src/molecules/InterventionModal/InterventionContent/InterventionInfo.tsx
Outdated
Show resolved
Hide resolved
app/src/molecules/InterventionModal/InterventionContent/InterventionInfo.tsx
Outdated
Show resolved
Hide resolved
…entionInfo.tsx Co-authored-by: Seth Foster <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17533 +/- ##
==========================================
+ Coverage 26.17% 27.17% +1.00%
==========================================
Files 2835 2840 +5
Lines 217682 218818 +1136
Branches 9276 9837 +561
==========================================
+ Hits 56971 59474 +2503
+ Misses 160694 159323 -1371
- Partials 17 21 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
smb2268
reviewed
Feb 18, 2025
| text={t('labware_quantity', { quantity: props.tagtext })} | ||
| shrinkToContent={true} | ||
| /> | ||
| ) : null} | ||
| </Flex> | ||
| <Divider |
There was a problem hiding this comment.
In the designs we should now only display this divider if a tag is present 🏷️
smb2268
reviewed
Feb 18, 2025
app/src/molecules/InterventionModal/InterventionContent/InterventionInfo.tsx
Outdated
Show resolved
Hide resolved
…entionInfo.tsx Co-authored-by: Sarah Breen <[email protected]>
smb2268
reviewed
Feb 18, 2025
app/src/molecules/InterventionModal/InterventionContent/InterventionInfo.tsx
Outdated
Show resolved
Hide resolved
smb2268
reviewed
Feb 19, 2025
app/src/molecules/InterventionModal/InterventionContent/InterventionInfo.tsx
Outdated
Show resolved
Hide resolved
smb2268
approved these changes
Feb 20, 2025
|
Mel approved :-) |
TamarZanzouri
deleted the
EXEC-1224-component-update-intervention-info-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://opentrons.atlassian.net/browse/EXEC-1224.
Add subtext and tagtext props to intervention modal.
Test Plan and Hands on Testing
Can follow storybook for changes. (not passing these props yet so can only view in storybook).
https://s3-us-west-2.amazonaws.com/opentrons-components/EXEC-1224-component-update-intervention-info-component/index.html?path=/docs/app-molecules-interventionmodal-interventioncontent-interventioninfo--docs
Changelog
Added 2 new props to intervention modal. subtext and tagtext.
Added conditional display.
fixed bug in storybook where it didnt show the location label.
Review requests
changes make sense? do we want to fix storybook rendering the slots?
Risk assessment
low. added 2 optional props.