Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, shared-data): add a new step for liquid classes in Transfer #17553

Draft
wants to merge 4 commits into
base: edge
Choose a base branch
from

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Feb 19, 2025

re AUTH-969

Overview

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 10.16949% with 106 lines in your changes missing coverage. Please review.

Project coverage is 25.16%. Comparing base (6233f7f) to head (8a491dc).
Report is 4 commits behind head on edge.

Files with missing lines Patch % Lines
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 6.54% 100 Missing ⚠️
...esigner/ProtocolSteps/StepForm/StepFormToolbox.tsx 0.00% 5 Missing ⚠️
...src/organisms/AssignLiquidsModal/LiquidToolbox.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17553       +/-   ##
===========================================
- Coverage   63.47%   25.16%   -38.31%     
===========================================
  Files        2840     3175      +335     
  Lines      218531   231755    +13224     
  Branches    18120    10487     -7633     
===========================================
- Hits       138708    58328    -80380     
- Misses      79630   173403    +93773     
+ Partials      193       24      -169     
Flag Coverage Δ
step-generation 4.35% <2.63%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/atoms/buttons/RadioButton.tsx 90.13% <100.00%> (-5.00%) ⬇️
shared-data/js/liquidClasses.ts 100.00% <100.00%> (ø)
...src/organisms/AssignLiquidsModal/LiquidToolbox.tsx 0.48% <0.00%> (-0.04%) ⬇️
...esigner/ProtocolSteps/StepForm/StepFormToolbox.tsx 5.07% <0.00%> (ø)
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 12.59% <6.54%> (-87.41%) ⬇️

... and 1994 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant