-
Notifications
You must be signed in to change notification settings - Fork 30
Code Contribution Rules
Timo Bruderek edited this page May 10, 2020
·
1 revision
Please follow these rules to get a structure into issues and pull-requests:
-
There should be an issue ticket for each problem.
-
Each PR has to have an associated issue
-
Each PR is just one logical function or fix. Not a combination of fixes and functions from different topics.
-
Every commit includes only one logical function or fix.
-
Make clear PRs without reverting commits or things like that. It makes that changes unclear and very difficult to review.
-
Please discuss/document the analysis of errors in the issue ticket and not in the PR.
-
New features should be discussed in an issue ticket until there is a clear understanding and documentation of the new feature. After that the implementation can be submitted via a PR.