Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google's Lighthouse via a CI check #1230

Open
kylemh opened this issue Oct 1, 2020 · 9 comments
Open

Use Google's Lighthouse via a CI check #1230

kylemh opened this issue Oct 1, 2020 · 9 comments

Comments

@kylemh
Copy link
Member

kylemh commented Oct 1, 2020

Feature request

Google's Lighthouse is a tool used by developers to get a simple measurement on a page's performance, accessibility score, and SEO rating. We should use it via some CI step (CircleCI, GitHub Actions, something else).

Proposed solution

Leverage Lighthouse in this repository's continuous integration against the landing page in a way that lets me confirm that we haven't strayed to far from the scores that https://www.operationcode.org/ is receiving. Also, remember to add the check to the .mergify.yml file so that automated dependency update PRs continue to operate.

Additional context

A quick search yields me many potential tools:

I think I'd prefer GitHub action so that we're parallelizing CI tasks; however, I'm open to using Orbs or even some other solution. I'll leave the evaluation of the best tool up to you.

@sahil9001
Copy link

@kylemh I would like to work on this one! Can you please guide me?

@kylemh
Copy link
Member Author

kylemh commented Oct 2, 2020

Hey @sahil9001 I don't have much time to contribute this month myself, but I can try to schedule some time to work together on October 29th. This ticket may not be available, but others may be!

@sahil9001
Copy link

Okay no problem, Thanks!

@kylemh
Copy link
Member Author

kylemh commented Oct 2, 2020

Feel free to email me.

@BhuwanChandra
Copy link
Contributor

@sahil9001 @kylemh is anyone working on this issue? I would like to work on this one.

@kylemh
Copy link
Member Author

kylemh commented Oct 5, 2020

Go for it!

@BhuwanChandra
Copy link
Contributor

@kylemh I have opened a PR for this issue.

@datphotogurl
Copy link

@kylemh is this issue resolved and ready to close? @Lianis-Operations and I are cleaning up the repos with any outstanding items.

@kylemh
Copy link
Member Author

kylemh commented Mar 12, 2021

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants