added google's Lighthouse CI check #1275

BhuwanChandra · 2020-10-06T11:15:56Z

Description of changes

added lighthouse ci check to get a measurement on the performance of website.

Issue Resolved

vercel · 2020-10-06T11:16:03Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook – ./

🔍 Inspect: https://vercel.com/operation-code/storybook/p4gavenvr
✅ Preview: https://storybook-git-lighthouse-ci.operation-code.vercel.app

operation-code – ./

🔍 Inspect: https://vercel.com/operation-code/operation-code/iphj0jsdq
✅ Preview: https://operation-code-git-lighthouse-ci.operation-code.now.sh

cypress · 2020-10-06T11:28:25Z

Test summary

80 • 0 • 0 • 0 • 1

Run details


Project	operation_code
Status	Passed
Commit	`173e8e0`
Started	Oct 30, 2020 10:11 PM
Ended	Oct 30, 2020 10:14 PM
Duration	02:27 💡
OS	Linux Debian - 10.5
Browser	Electron 83

View run in Cypress Dashboard ➡️

Flakiness

	cypress/integration/join.spec.js		1
1	join > should NOT be able to register when zipcode contains only spaces

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

.github/workflows/lighthouse.yml

BhuwanChandra · 2020-10-07T11:12:24Z

.github/workflows/lighthouse.yml

+        uses: treosh/lighthouse-ci-action@v3
+        with:
+          urls: |
+            https://operationcode.org/


I think it will compare against the urls we have specified here in urls field.

ah okay - willing to try it! Any reason there's no feedback in this PR from Lighthouse?

Its because I have added the lighthouse check on push not on pull requests. I think, I also need to add pull requests into it.

I have made some changes, now it's showing the lighthouse check.

kylemh · 2020-10-08T16:21:01Z

I see

No GitHub token set, skipping GitHub status check.

in the workflow spot.

Do we need to do something about that?

Additionally, I'm still not sure what to expect from this check. What would make it fail?

BhuwanChandra · 2020-10-10T04:29:09Z

A status check, if configured, is a message that appears on every PR and typically includes information such as the results of a test or the success of a build.

You need to set lighthouse github app in this repository to get the status checks and performance scores on every pull requests.

something like this.

to set github status check:

go to https://github.com/apps/lighthouse-ci
add lighthouse CI to this repository
add LHCI_GITHUB_APP_TOKEN to the secrets of the repository.

Or we can also add a bot to comment lighthouse scores on each PR.

this is totally optional, otherwise we need to go to the details each time to check the performance scores.

basically in these checks, we can run our lighthouse checks against some predefined performance scores (we need add them into our lighthouserc.js file) and if the current scores are below those predefined scores then this check will get failed.

currently I haven't defined any scores yet, If you want me add the scores let me know I will add some performance scores.

and also let me know if you have enabled the github status check then I need to make some changes in lighthouse.yaml file in order to make it work.

kylemh · 2020-10-10T16:39:22Z

Awesome. Added the token: LHCI_GITHUB_APP_TOKEN to GitHub. Updated your branch! Let's see if it works 🌟

…t-end into lighthouse-CI

BhuwanChandra · 2020-10-11T05:53:20Z

I have made the required changes but still it is showing No GitHub token set, skipping GitHub status check this, can you check once if LHCI_GITHUB_APP_TOKEN is in the secrets of the repository or not?
I have added some minimum scores for each checks and now the checks will get failed if the performance scores are below those scores.

kylemh · 2020-10-15T00:08:56Z

@BhuwanChandra I think it was an annoying typo issue. The actual GitHub app refers to the would-be token as: LHCI_GITHUB_APP_TOKEN, but this workflow expects LHCI_GITHUB_TOKEN 🙃 treosh/lighthouse-ci-action#60 (comment)

kylemh · 2020-10-15T00:45:23Z

Hmmmm, not sure what else could be going on.

I have the token added via secrets under both monikers - just in case:

I've had them in since you began working on this - ignore the time stamp - I just moved them to the org level instead of just this repository.

…o lighthouse-CI

…t-end into lighthouse-CI

kylemh · 2020-10-18T19:31:46Z

Do you want to try this one out https://github.com/OskarAhl/Lighthouse-github-action-comment/blob/main/.github/workflows/lighthouse-on-vercel-preview-url.yml

BhuwanChandra · 2020-10-19T15:38:05Z

Ok, I will try this one!

codeclimate · 2020-10-30T22:20:02Z

Code Climate has analyzed commit 173e8e0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 83.9% (0.0% change).

View more on Code Climate.

BhuwanChandra added 2 commits October 6, 2020 16:00

added lighthouse ci action

b3ee6db

added in mergify

e7453cd

vercel bot deployed to Preview – storybook October 6, 2020 11:16 View deployment

vercel bot deployed to Preview – operation-code October 6, 2020 11:16 View deployment

BhuwanChandra changed the title ~~Lighthouse ci~~ added google's Lighthouse CI check Oct 6, 2020

kylemh reviewed Oct 6, 2020

View reviewed changes

.github/workflows/lighthouse.yml Outdated Show resolved Hide resolved

BhuwanChandra commented Oct 7, 2020

View reviewed changes

updated lighthouse actions

2479882

vercel bot deployed to Preview – operation-code October 8, 2020 07:11 View deployment

vercel bot deployed to Preview – storybook October 8, 2020 07:11 View deployment

Merge branch 'main' into lighthouse-CI

6363d8f

vercel bot deployed to Preview – storybook October 10, 2020 16:39 View deployment

vercel bot deployed to Preview – operation-code October 10, 2020 16:39 View deployment

BhuwanChandra added 2 commits October 11, 2020 11:05

added github status check and some assertions

e2effde

Merge branch 'lighthouse-CI' of https://github.com/BhuwanChandra/fron…

4079bfc

…t-end into lighthouse-CI

vercel bot deployed to Preview – storybook October 11, 2020 05:39 View deployment

vercel bot deployed to Preview – operation-code October 11, 2020 05:39 View deployment

Merge branch 'main' into lighthouse-CI

8f4a128

vercel bot deployed to Preview – operation-code October 14, 2020 22:05 View deployment

vercel bot deployed to Preview – storybook October 14, 2020 22:05 View deployment

fix typo

f93b932

vercel bot deployed to Preview – storybook October 15, 2020 00:07 View deployment

vercel bot deployed to Preview – operation-code October 15, 2020 00:07 View deployment

fix typo - for real!

9b07d29

vercel bot deployed to Preview – storybook October 15, 2020 00:08 View deployment

vercel bot deployed to Preview – operation-code October 15, 2020 00:08 View deployment

BhuwanChandra added 3 commits October 18, 2020 09:42

Merge branch 'main' of https://github.com/OperationCode/front-end int…

78db86a

…o lighthouse-CI

replaced treosh with lhci

4da769b

Merge branch 'lighthouse-CI' of https://github.com/BhuwanChandra/fron…

8c688ad

…t-end into lighthouse-CI

vercel bot deployed to Preview – operation-code October 18, 2020 04:54 View deployment

vercel bot deployed to Preview – storybook October 18, 2020 04:54 View deployment

updated lighthouse check

397540d

vercel bot deployed to Preview – operation-code October 21, 2020 18:11 View deployment

vercel bot deployed to Preview – storybook October 21, 2020 18:11 View deployment

Merge branch 'main' into lighthouse-CI

f1a5621

vercel bot deployed to Preview – operation-code October 22, 2020 21:56 View deployment

vercel bot deployed to Preview – storybook October 22, 2020 21:57 View deployment

Merge branch 'main' into lighthouse-CI

a4e554c

vercel bot deployed to Preview – storybook October 30, 2020 20:25 View deployment

vercel bot deployed to Preview – operation-code October 30, 2020 20:25 View deployment

Merge branch 'main' into lighthouse-CI

173e8e0

vercel bot deployed to Preview – storybook October 30, 2020 22:09 View deployment

vercel bot deployed to Preview – operation-code October 30, 2020 22:09 View deployment

kylemh closed this Sep 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added google's Lighthouse CI check #1275

added google's Lighthouse CI check #1275

BhuwanChandra commented Oct 6, 2020

vercel bot commented Oct 6, 2020 •

edited

Loading

cypress bot commented Oct 6, 2020 •

edited

Loading

BhuwanChandra Oct 7, 2020 •

edited

Loading

kylemh Oct 7, 2020

BhuwanChandra Oct 8, 2020

BhuwanChandra Oct 8, 2020 •

edited

Loading

kylemh commented Oct 8, 2020

BhuwanChandra commented Oct 10, 2020 •

edited

Loading

kylemh commented Oct 10, 2020 •

edited

Loading

BhuwanChandra commented Oct 11, 2020 •

edited

Loading

kylemh commented Oct 15, 2020

kylemh commented Oct 15, 2020

kylemh commented Oct 18, 2020

BhuwanChandra commented Oct 19, 2020

codeclimate bot commented Oct 30, 2020

added google's Lighthouse CI check #1275

added google's Lighthouse CI check #1275

Conversation

BhuwanChandra commented Oct 6, 2020

Description of changes

Issue Resolved

vercel bot commented Oct 6, 2020 • edited Loading

storybook – ./

operation-code – ./

cypress bot commented Oct 6, 2020 • edited Loading

Test summary

Run details

Flakiness

BhuwanChandra Oct 7, 2020 • edited Loading

Choose a reason for hiding this comment

kylemh Oct 7, 2020

Choose a reason for hiding this comment

BhuwanChandra Oct 8, 2020

Choose a reason for hiding this comment

BhuwanChandra Oct 8, 2020 • edited Loading

Choose a reason for hiding this comment

kylemh commented Oct 8, 2020

BhuwanChandra commented Oct 10, 2020 • edited Loading

kylemh commented Oct 10, 2020 • edited Loading

BhuwanChandra commented Oct 11, 2020 • edited Loading

kylemh commented Oct 15, 2020

kylemh commented Oct 15, 2020

kylemh commented Oct 18, 2020

BhuwanChandra commented Oct 19, 2020

codeclimate bot commented Oct 30, 2020

vercel bot commented Oct 6, 2020 •

edited

Loading

cypress bot commented Oct 6, 2020 •

edited

Loading

BhuwanChandra Oct 7, 2020 •

edited

Loading

BhuwanChandra Oct 8, 2020 •

edited

Loading

BhuwanChandra commented Oct 10, 2020 •

edited

Loading

kylemh commented Oct 10, 2020 •

edited

Loading

BhuwanChandra commented Oct 11, 2020 •

edited

Loading