Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Container and Content components to Typescript #1803

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

recondesigns
Copy link
Contributor

Description of changes

Migrating components included all test and storybook files for each.

  • Migrated Container component to Typescript, removed prop-types, and added a props type
    • updated snapshot for DonateSection due to change with the Container component
  • Migrated Content component to Typescript, removed prop-types, and added a props type
    • updated snapshots for LogoSection, FontSection, and ColorSection due to change in Content component

Issue Resolved

Fixes #NA

Screenshots/GIFs

All new .tsx files

Screenshot 2024-03-03 at 11 25 09 AM

@recondesigns recondesigns requested a review from kylemh March 3, 2024 17:42
Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 6:28pm
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 6:28pm

components/Container/Container.tsx Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Mar 3, 2024

Code Climate has analyzed commit e7c2b26 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 79.4% (0.3% change).

View more on Code Climate.

Copy link

cypress bot commented Mar 3, 2024

Passing run #4652 ↗︎

0 25 0 0 Flakiness 0

Details:

removed commented out imports
Project: operation_code Commit: e7c2b2649f
Status: Passed Duration: 03:02 💡
Started: Mar 3, 2024 6:29 PM Ended: Mar 3, 2024 6:32 PM

Review all test suite changes for PR #1803 ↗︎

@kylemh kylemh merged commit 98b3928 into main Mar 4, 2024
18 checks passed
@kylemh kylemh deleted the migrate-container-and-content-to-ts branch March 4, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants