WIP - Migrate Forms to Typescript #1810
Open
+2,853
−2,783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #4697 ↗︎
Details:
Review all test suite changes for PR #1810 ↗︎ |
|||||||||||||||
recondesigns
commented
Mar 14, 2024
| @@ -59,7 +58,7 @@ describe('Select', () => { | |||
| const validate = () => ({ [fieldName]: 'Required' }); | |||
|
|
|||
| const { container, findByText } = render( | |||
| <Formik initialValues={{ [fieldName]: '' }} validate={validate}> | |||
| <Formik initialValues={{ [fieldName]: '' }} validate={validate} onSubmit={() => {}}> | |||
There was a problem hiding this comment.
Having a hard time with this test (and the rest of the tests in the "interactions" suite).
I am getting the idea that the Alert is not being rendered in the test, so there is nothing for findByText('Required') to find?
kylemh
reviewed
Mar 15, 2024
kylemh
reviewed
Mar 15, 2024
…ront-end into migrate-forms-typescript
recondesigns
added
the
help wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating
FormandFormscomponents to Typescript.Issue Resolved
Fixes #NA
Screenshots/GIFs