Display featured jobs on Jobs page, above search results #985
Conversation
Added Font Awesome icons similar to SVGs in search results
|
@ksmacleod99 @hollomancer Please post an update in here or reach out via Slack when the initial content is ready for this. |
| "source": "GitHub", | ||
| "sourceUrl": "https://www.github.com", | ||
| "city": "Austin", | ||
| "state": "texas", |
There was a problem hiding this comment.
This JSON file is just mock data for now. Its content will be replaced with actual featured jobs, or the JSON file will discarded completely once the API endpoint is ready.
| <div> | ||
| <div className={styles.job}> | ||
| <div> | ||
| <OutboundLink href={sourceUrl} analyticsEventLabel={`[FeaturedJob] ${sourceUrl}`}> |
src/scenes/home/jobs/jobs.js
Outdated
| @@ -29,11 +32,39 @@ class Jobs extends Component { | |||
| }; | |||
| tryRunInit(); | |||
| } | |||
|
|
|||
| featuredJobs | |||
There was a problem hiding this comment.
I think you need to delete this line.
src/scenes/home/jobs/jobs.js
Outdated
| <Section title="Featured Jobs" theme="white"> | ||
| <div className={styles.featuredJobsContainer}> | ||
| <div className={styles.featuredJobs}> | ||
| {featuredJobs} |
There was a problem hiding this comment.
You should do
{FeaturedJobsData.length() > 0 ? featuredJobs : <div>some default content expressed a lack of featured jobs and how to get one featured</div>}
There was a problem hiding this comment.
Good idea. We should probably have a contact link somewhere here. It should display whether or not there are any featured jobs exist. Can start off with an email link to @ksmacleod99 for now.
There was a problem hiding this comment.
@kylemh As long as we have the contact link (explaining how to get a featured job), we can probably go live with this sooner (without any featured jobs yet). Test out the waters and see if we get anyone contacting us.
There was a problem hiding this comment.
Agreed. You've got the structure in place for jobs when they come in.
I'd say create the default, see what traffic - if any - we get towards that feature.
Back-end can look at the JSON in this PR as an example to prepare for, and the ticket can be ✅
There was a problem hiding this comment.
@kylemh I also went ahead and set the three 'mock' Jobs in the JSON file as "status": "inactive", so they won't display on the page. I think back-end PR is actually nearing completion (to serve up API data), but I can leave the mock JSON data in there until then as a guide.
Also cleaned up code in response to code review
|
@kylemh I added a contact link in response to your comment - it will display below featured jobs, or if there are no jobs, it can serve as the placeholder text:
|
This should prevent them from displaying. Also added '(Mock Data)' to their titles to prevent any confusion. These should be replaced with actual featured jobs when those exist, or this file can be replaced when the API is ready to serve up real data.
src/scenes/home/jobs/jobs.js
Outdated
| </div> | ||
| </div> | ||
| <p className={styles.contact}> | ||
| Are you hiring? <a href="mailto:[email protected]">Contact</a> us to post your job opening with Operation Code! |
There was a problem hiding this comment.
Can you use the ExternalLink component here? Then it will be good to go.
There was a problem hiding this comment.
Fixed to use the OutboundLink component in latest commit, also updated email contact address (sending them to Kelly since she'll be coordinating this, confirmed usage with her already).
| } | ||
|
|
||
| .whiteCondensed { | ||
| composes: white; |
There was a problem hiding this comment.
woah - never knew about this! thanks for showing me something new.
There was a problem hiding this comment.
Yeah, there's a couple other places we've been using composes w/ CSS Modules in the app - it's a nice way of composing multiple classes together to create a new one, so you only need to apply one CSS class to an element instead of multiple ones (which is sometimes seen w/ patterns like BEM).
|
@hollomancer @ksmacleod99 Update: Not going live yet - awaiting featured jobs content per Slack discussion in
|
Don't display those properties if they are falsey
jjhampton
force-pushed
the
982-highlighted-jobs
branch
from
715f5ab to
cfd6461
Compare
|
The first set of featured job data has been posted in #982 , and has been added to the static JSON file. |
Description of changes
Displays 'Featured Jobs' section above Ziprecruiter job search section on /jobs page.
Screenshot w/ mock data:
Issue Resolved
MVP requirements for #982
Note - do not merge this yet, as we still need content - the actual 'featured' jobs which will be highlighted at the top of the page. The front-end code is ready for review, I'm currently pulling in data from the static
featuredJobs.jsonfile, which only contains mock data for now. This new feature should not go live until we actually have featured jobs to display on the page. They can be loaded fromfeaturedJobs.jsonor the API & DB (see Back-end PR # 366)