Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SMS opt-in data #68

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Handle SMS opt-in data #68

merged 3 commits into from
Jul 20, 2023

Conversation

harveysanders
Copy link
Contributor

@harveysanders harveysanders commented Jul 20, 2023 •
edited
Loading

Update API to accept smsOptIn boolean field on SignUp JSON.

  • If smsOptIn == false, we don't send a text via Twilio
  • else we send an opt-in confirmation followed up by the rest of the messages:
image

Note: Merging this will cause messages to stop sending if the OS website PR is not merged as the smsOptIn field will default to false.
We also need to ensure that the Twilio Messaging Service(s) used by this service is configured to listen for "STOP" messages.

@harveysanders harveysanders linked an issue Jul 20, 2023 that may be closed by this pull request
Handle SMS Opt-In Selection #67
Closed
3 tasks
@harveysanders harveysanders mentioned this pull request Jul 20, 2023
Closed
3 tasks
@harveysanders harveysanders merged commit 5015bfa into main Jul 20, 2023
@harveysanders harveysanders deleted the 67-handle-sms-opt-in-selection branch July 20, 2023 21:49
@harveysanders harveysanders mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbarnum4 ptbarnum4 ptbarnum4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle SMS Opt-In Selection
3 participants
@harveysanders @ptbarnum4 @actions-user