Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oppijanumerorekisteri - integraatio #125

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Conversation

saku-koodari
Copy link
Contributor

@saku-koodari saku-koodari commented Sep 24, 2024

Hakee Magdalena Sallinen - tiedot ONR:stä.

Flow - kopioitu vahvasti https://github.com/Opetushallitus/oppijanumerorekisteri/tree/master/example/src/main/java/fi/vm/sade/oppijanumerorekisteri/example
Yleiskäyttöisten suosituksesta. YK suosittelee että käytetään java.net.http restTemplate:n sijaan. Siksi tein PoC:n aluksi tällä. (Mun puolesta tämän voi vaikka jo mergetä). Mutta nyt kun toimii, voisin periaatteessa testata vielä miten saisi toimimaan RestTemplatella, jos en saa toimimaan, käytetään java.net.http.

@saku-koodari saku-koodari requested a review from a team as a code owner September 24, 2024 09:37
@saku-koodari saku-koodari marked this pull request as draft September 24, 2024 12:56
@saku-koodari saku-koodari force-pushed the feat/onr4-kiss branch 2 times, most recently from a183636 to 7ba53ec Compare September 25, 2024 09:48
@saku-koodari saku-koodari self-assigned this Sep 25, 2024
@saku-koodari saku-koodari marked this pull request as ready for review September 25, 2024 09:48
@saku-koodari saku-koodari force-pushed the feat/onr4-kiss branch 2 times, most recently from a8c9857 to 917f366 Compare September 25, 2024 10:02
@saku-koodari saku-koodari force-pushed the feat/onr4-kiss branch 6 times, most recently from 11fa205 to d927f83 Compare September 25, 2024 13:26
@saku-koodari saku-koodari force-pushed the feat/onr4-kiss branch 2 times, most recently from f001eaf to 90e90d6 Compare September 25, 2024 13:31
@saku-koodari saku-koodari merged commit bf4398c into main Sep 27, 2024
12 checks passed
@saku-koodari saku-koodari deleted the feat/onr4-kiss branch September 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants