Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OY-4695 Cleanup: update Java and library versions, add extra logging #11

Merged
merged 24 commits into from
Feb 28, 2024

Conversation

vaeinoe
Copy link
Contributor

@vaeinoe vaeinoe commented Feb 20, 2024

Minor change:

  • Log the actual secret for "old or invalid secret" type errors so we can track who encountered the error

Major batch cleanup:

  • Update Java to latest LTS
  • Update Clojure, ClojureScript and library versions (including latest reagent / re-frame and React 17->18)
  • Bump PostgreSQL to v15 in local dev env (matching forthcoming updates)
  • Remove Cypress since there were no tests written, rename test scripts to "test" instead of "cypress", remove "cypressid" attributes from DOM, whoever integrates eg. Playwright will want to define their own anyway
  • Convert some files with CRLF line endings to LF: makes for a harder to read diff for some files, easier to edit code later
  • Remove unused UI components and dead code mainly on the frontend side

Works on my machine -tm- against untuva env zooming through basic views with an existing secret, all tests pass, builds on GH Actions.

Notes:

  1. Reagent complains about reagent.dom/dom-node being deprecated in the latest version when displaying paytrail-payment-form, but it's still supported in the current version so let's leave it as is for now (the alternative solution would be to use React refs directly).
  2. There may still be useless (JS / Clojure) library dependencies, some may have been originally copy-pasted from another project this is based on. Doing "conservative" cleaning (still a lot) in this PR.

@vaeinoe vaeinoe marked this pull request as ready for review February 21, 2024 13:25
@vaeinoe vaeinoe force-pushed the OY-4695-update-versions branch from 981548a to c735a63 Compare February 28, 2024 12:24
@vaeinoe vaeinoe merged commit 290662a into master Feb 28, 2024
2 checks passed
@vaeinoe vaeinoe deleted the OY-4695-update-versions branch February 28, 2024 12:30
hajoa pushed a commit that referenced this pull request Feb 25, 2025
OY-4695 Cleanup: update Java and library versions, add extra logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant