Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCi to Github actions migration #33

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

souzamari
Copy link

@souzamari souzamari commented Oct 22, 2024

This PR migrates existing CircleCI workflow of optable-ios-sdk to GitHub actions

The runners needed to be updated and we can't use the same runner for setup and for build:

  • for setup we must use macos-13 otherwise the ruby version is unavailable. If the dependencies are cached it won't fail with macos-14, but we should not rely on the cache.
  • for building we must use macos-14, otherwise the build will fail

The CircleCI workflow ran in 2 different cases:

  • pull-request runs the tests, build-demo-swift and build-demo-objc: jobs for the standard build
  • tagging with vX.Y.Z runs the tests, build-demo-swift, build-demo-objc: and success-slack-notify

Slack notifications will be added back eventually when a reusable action is created, for now we're ignoring it as it's not a critical part of the build process.

The workflow is essentially the same for pull-requests and tagging, for the sake of simplicity we are using the same workflow in the github action, eventually it could be split in 2. Contrary to the web-sdk, the publishing step needs to be done manually and the process is described in the releasing.md file.

The only artifact that was published with CircleCi was the build log
image

This github action creates the following artifacts:

  • test output
  • the pods for each demo
  • the build log for each demo

Slack integration notification:
Screenshot 2024-11-28 at 3 27 46 PM

@souzamari souzamari self-assigned this Oct 22, 2024
@souzamari souzamari force-pushed the ci/add-ci-workflow branch 2 times, most recently from 7ffc38f to 6ea6a4c Compare October 22, 2024 19:51
@souzamari souzamari force-pushed the ci/add-ci-workflow branch 3 times, most recently from 97aaecd to 0225109 Compare October 23, 2024 19:11
@Yoshiji
Copy link

Yoshiji commented Oct 23, 2024

neat 👌

@Yoshiji Yoshiji self-requested a review October 24, 2024 14:20
@souzamari souzamari force-pushed the ci/add-ci-workflow branch 2 times, most recently from 752c1c1 to 9c86345 Compare October 24, 2024 15:14
@souzamari souzamari force-pushed the ci/add-ci-workflow branch 2 times, most recently from 7cd130d to c861068 Compare October 24, 2024 17:09
@dany-pellerin dany-pellerin force-pushed the ci/add-ci-workflow branch 10 times, most recently from e27fb2a to d98ab00 Compare November 14, 2024 16:02
@dany-pellerin dany-pellerin changed the title CI: Initial gha workflow - run tests CircleCi to Github actions migration Nov 14, 2024
@souzamari souzamari force-pushed the ci/add-ci-workflow branch 4 times, most recently from 19fac5b to 31c9bbd Compare November 28, 2024 20:28
Copy link

@dany-pellerin dany-pellerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants