Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mongo and redis optional dependencies #238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make mongo and redis optional dependencies #238

wants to merge 2 commits into from

Conversation

zamiang
Copy link

@zamiang zamiang commented Apr 26, 2017

closes #221

@deksden
Copy link

deksden commented Jul 13, 2017 •
edited
Loading

Good suggestion!

Mongo & Redis are not required when we use 3-d party driver like Knex-based or Sequelize-based (or even we are just developing with in-memory database).

update: shouldn't we need mention proper install steps in readme?

npm install
npm install redis mongo

@zamiang
Copy link
Author

zamiang commented Jul 13, 2017

@deksden also a good suggestion!

Added a note about installing redis and mongo to the install step of the readme

@zamiang
Copy link
Author

zamiang commented Jul 28, 2017

@manast any word on this? I believe this is a low risk, simple change but let me know if I can improve it in any dimension.

@zamiang
Copy link
Author

zamiang commented Feb 7, 2018

@manast any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can redis and mongodb dependencies be made optional ?
2 participants
@zamiang @deksden